[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-07 Thread Boris Brezillon
On Tue, 7 Jun 2016 08:28:18 + Meng Yi wrote: > Hi Boris, > > > Changes in v5: > > - drop the best_encoder() implementation > > > > Why best_encoder() droped? It's not needed anymore? Nope, not after this series [1]. [1]http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/432

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-07 Thread Meng Yi
Hi Boris, > Changes in v5: > - drop the best_encoder() implementation > Why best_encoder() droped? It's not needed anymore? Regards, Meng

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-07 Thread Boris Brezillon
Hi Meng, On Tue, 7 Jun 2016 02:40:56 + Meng Yi wrote: > Hi Boris, > > Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8 > > > > > > > + gpiod_set_value(sii902x->reset_gpio, 1); > > > > + > > > > + msleep(100); > > > Ouch that is some juicy number

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-07 Thread Meng Yi
Hi Boris, Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8 > > > > + gpiod_set_value(sii902x->reset_gpio, 1); > > > + > > > + msleep(100); > > Ouch that is some juicy number. Can we get a comment with > > reasoning/origin of it ? > > As already explained

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Emil Velikov
On 3 June 2016 at 11:02, Boris Brezillon wrote: > Hi Emil, > > On Fri, 3 Jun 2016 10:38:49 +0100 > Emil Velikov wrote: > >> Hi Boris. >> >> On 2 June 2016 at 16:00, Boris Brezillon >> wrote: >> >> > +static void sii902x_reset(struct sii902x *sii902x) >> > +{ >> > + if (!sii902x->reset_gpio

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Lucas Stach
Am Freitag, den 03.06.2016, 10:38 +0100 schrieb Emil Velikov: > Hi Boris. [...] > > > + > > + if (client->irq > 0) { > I was always confused which is the correct way to check this >= 0 vs > > 0. DRM has both :-\ > Do you have any suggestions, should be 'mass convert' DRM to use only > one of

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Alexandre Belloni
Hi, On 03/06/2016 at 10:38:49 +0100, Emil Velikov wrote : > On 2 June 2016 at 16:00, Boris Brezillon > wrote: > > + > > + if (client->irq > 0) { > I was always confused which is the correct way to check this >= 0 vs > > 0. DRM has both :-\ > Do you have any suggestions, should be 'mass conv

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Boris Brezillon
Hi Emil, On Fri, 3 Jun 2016 10:38:49 +0100 Emil Velikov wrote: > Hi Boris. > > On 2 June 2016 at 16:00, Boris Brezillon > wrote: > > > +static void sii902x_reset(struct sii902x *sii902x) > > +{ > > + if (!sii902x->reset_gpio) > > + return; > > + > This is wrong (reset_gp

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Emil Velikov
Hi Boris. On 2 June 2016 at 16:00, Boris Brezillon wrote: > +static void sii902x_reset(struct sii902x *sii902x) > +{ > + if (!sii902x->reset_gpio) > + return; > + This is wrong (reset_gpio is err_ptr) although we can/should nuke it all together. See below for reasoning. > +

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Boris Brezillon
Hi Enric, On Thu, 2 Jun 2016 23:47:23 +0200 Enric Balletbo Serra wrote: > > +static int sii902x_get_modes(struct drm_connector *connector) > > +{ > > + struct sii902x *sii902x = connector_to_sii902x(connector); > > + struct regmap *regmap = sii902x->regmap; > > + u32 bus_form

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-02 Thread Enric Balletbo Serra
Hi Boris, A few comments below ... 2016-06-02 17:00 GMT+02:00 Boris Brezillon : > Add basic support for the sii902x RGB -> HDMI bridge. > This driver does not support audio output yet. > > Signed-off-by: Boris Brezillon > Tested-by: Nicolas Ferre > --- > Hello, > > This patch is only adding bas

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-02 Thread Boris Brezillon
Add basic support for the sii902x RGB -> HDMI bridge. This driver does not support audio output yet. Signed-off-by: Boris Brezillon Tested-by: Nicolas Ferre --- Hello, This patch is only adding basic support for the sii9022 chip. As stated in the commit log, there's no audio support, but the dr