Re: [PATCH v5 08/20] drm/lima: use scheduler dependency tracking

2021-08-13 Thread Qiang Yu
Thanks for the remind, indeed miss a lock. Patch is: Reviewed-by: Qiang Yu Regards, Qiang On Fri, Aug 13, 2021 at 3:28 AM Daniel Vetter wrote: > > On Thu, Aug 05, 2021 at 12:46:53PM +0200, Daniel Vetter wrote: > > Nothing special going on here. > > > > Aside reviewing the code, it seems like dr

Re: [PATCH v5 08/20] drm/lima: use scheduler dependency tracking

2021-08-12 Thread Daniel Vetter
On Thu, Aug 05, 2021 at 12:46:53PM +0200, Daniel Vetter wrote: > Nothing special going on here. > > Aside reviewing the code, it seems like drm_sched_job_arm() should be > moved into lima_sched_context_queue_task and put under some mutex > together with drm_sched_push_job(). See the kerneldoc for

[PATCH v5 08/20] drm/lima: use scheduler dependency tracking

2021-08-05 Thread Daniel Vetter
Nothing special going on here. Aside reviewing the code, it seems like drm_sched_job_arm() should be moved into lima_sched_context_queue_task and put under some mutex together with drm_sched_push_job(). See the kerneldoc for drm_sched_push_job(). v2: Rebase over renamed functions to add dependenc