Re: [EXTERNAL] Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-21 Thread Danilo Krummrich
On 8/21/23 10:30, Donald Robson wrote: Hi Danilo, Thanks for the feedback. On the subject of locking, I have dma_resv locking in another branch where I'm trying to enable bind queues, but I didn't think I needed locking for the single, synchronous operations seen here. Would a mutex on the gem

Re: [EXTERNAL] Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-21 Thread Donald Robson
Hi Danilo, Thanks for the feedback. On the subject of locking, I have dma_resv locking in another branch where I'm trying to enable bind queues, but I didn't think I needed locking for the single, synchronous operations seen here. Would a mutex on the gem object wrapper suffice? Thanks, Donald O

Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-18 Thread Jann Horn
On Wed, Aug 16, 2023 at 10:25 AM Sarah Walker wrote: > Add a GEM implementation based on drm_gem_shmem, and support code for the > PowerVR GPU MMU. The GPU VA manager is used for address space management. [...] > +/** > + * pvr_mmu_flush() - Request flush of all MMU caches. > + * @pvr_dev: Target

Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-18 Thread Danilo Krummrich
Hi Sarah, On Wed, Aug 16, 2023 at 09:25:23AM +0100, Sarah Walker wrote: > Add a GEM implementation based on drm_gem_shmem, and support code for the > PowerVR GPU MMU. The GPU VA manager is used for address space management. > > Changes since v4: > - Correct sync function in vmap/vunmap function d

Re: [EXTERNAL] Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-18 Thread Sarah Walker
On Fri, 2023-08-18 at 00:42 +0200, Jann Horn wrote: > *** CAUTION: This email originates from a source not known to Imagination > Technologies. Think before you click a link or open an attachment *** > > Hi! > > Thanks, I think it's great that Imagination is writing an upstream > driver for Powe

Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-17 Thread Jann Horn
Hi! Thanks, I think it's great that Imagination is writing an upstream driver for PowerVR. :) On Wed, Aug 16, 2023 at 10:25 AM Sarah Walker wrote: > Add a GEM implementation based on drm_gem_shmem, and support code for the > PowerVR GPU MMU. The GPU VA manager is used for address space managemen