Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-29 Thread Luca Ceresoli
On Wed, 29 Jan 2025 14:22:30 +0200 Dmitry Baryshkov wrote: > On Wed, Jan 29, 2025 at 12:51:53PM +0100, Luca Ceresoli wrote: > > Hi Maxime, > > > > On Tue, 28 Jan 2025 15:49:23 +0100 > > Maxime Ripard wrote: > > > > > Hi, > > > > > > On Wed, Jan 22, 2025 at 05:12:30PM +0100, Luca Ceresoli wr

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-29 Thread Dmitry Baryshkov
On Wed, Jan 29, 2025 at 12:51:53PM +0100, Luca Ceresoli wrote: > Hi Maxime, > > On Tue, 28 Jan 2025 15:49:23 +0100 > Maxime Ripard wrote: > > > Hi, > > > > On Wed, Jan 22, 2025 at 05:12:30PM +0100, Luca Ceresoli wrote: > > > On Wed, 8 Jan 2025 17:02:04 +0100 > > > Maxime Ripard wrote: > > > >

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-29 Thread Luca Ceresoli
Hi Maxime, On Tue, 28 Jan 2025 15:49:23 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Jan 22, 2025 at 05:12:30PM +0100, Luca Ceresoli wrote: > > On Wed, 8 Jan 2025 17:02:04 +0100 > > Maxime Ripard wrote: > > > > [...] > > > > > > > > And we'll also need some flag in drm_bridge to indicate t

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-28 Thread Maxime Ripard
Hi, On Wed, Jan 22, 2025 at 05:12:30PM +0100, Luca Ceresoli wrote: > On Wed, 8 Jan 2025 17:02:04 +0100 > Maxime Ripard wrote: > > [...] > > > > > > And we'll also need some flag in drm_bridge to indicate that the > > > > > device > > > > > is gone, similar to what drm_dev_enter()/drm_dev_exit(

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-22 Thread Luca Ceresoli
Hi Maxime, On Wed, 8 Jan 2025 17:02:04 +0100 Maxime Ripard wrote: [...] > > > > And we'll also need some flag in drm_bridge to indicate that the device > > > > is gone, similar to what drm_dev_enter()/drm_dev_exit() provides, > > > > because now your bridge driver sticks around for much longer

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-08 Thread Maxime Ripard
On Wed, Jan 08, 2025 at 04:24:29PM +0100, Luca Ceresoli wrote: > Hi Maxime, Dmitry, > > thanks both for the useful review! > > On Mon, 6 Jan 2025 14:24:00 +0200 > Dmitry Baryshkov wrote: > > > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > > > Hi, > > > > > > Most of these comments

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-08 Thread Luca Ceresoli
On Tue, 7 Jan 2025 12:35:15 +0200 Dmitry Baryshkov wrote: > On Mon, Jan 06, 2025 at 03:49:48PM +0100, Maxime Ripard wrote: > > On Mon, Jan 06, 2025 at 02:24:00PM +0200, Dmitry Baryshkov wrote: > > > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > Most of

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-08 Thread Luca Ceresoli
Hi Maxime, Dmitry, thanks both for the useful review! On Mon, 6 Jan 2025 14:24:00 +0200 Dmitry Baryshkov wrote: > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > Hi, > > > > Most of these comments affect your earlier patches, but let's work on > > the API-level view. > > > > On Tue,

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-07 Thread Maxime Ripard
On Tue, Jan 07, 2025 at 12:35:15PM +0200, Dmitry Baryshkov wrote: > On Mon, Jan 06, 2025 at 03:49:48PM +0100, Maxime Ripard wrote: > > On Mon, Jan 06, 2025 at 02:24:00PM +0200, Dmitry Baryshkov wrote: > > > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > Most

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-07 Thread Dmitry Baryshkov
On Mon, Jan 06, 2025 at 03:49:48PM +0100, Maxime Ripard wrote: > On Mon, Jan 06, 2025 at 02:24:00PM +0200, Dmitry Baryshkov wrote: > > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > > > Hi, > > > > > > Most of these comments affect your earlier patches, but let's work on > > > the API-l

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-06 Thread Maxime Ripard
On Mon, Jan 06, 2025 at 02:24:00PM +0200, Dmitry Baryshkov wrote: > On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > > > Hi, > > > > Most of these comments affect your earlier patches, but let's work on > > the API-level view. > > > > On Tue, Dec 31, 2024 at 11:39:58AM +0100, Luca Ceresoli wr

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-06 Thread Dmitry Baryshkov
On Mon, 6 Jan 2025 at 12:39, Maxime Ripard wrote: > > Hi, > > Most of these comments affect your earlier patches, but let's work on > the API-level view. > > On Tue, Dec 31, 2024 at 11:39:58AM +0100, Luca Ceresoli wrote: > > + * When using refcounted mode, the driver should allocate ``struct > > +

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-06 Thread Maxime Ripard
Hi, Most of these comments affect your earlier patches, but let's work on the API-level view. On Tue, Dec 31, 2024 at 11:39:58AM +0100, Luca Ceresoli wrote: > + * When using refcounted mode, the driver should allocate ``struct > + * my_bridge`` using regular allocation (as opposed to ``devm_`` or

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2025-01-02 Thread Luca Ceresoli
Hello Randy, On Tue, 31 Dec 2024 09:54:41 -0800 Randy Dunlap wrote: > Hi-- > > On 12/31/24 2:39 AM, Luca Ceresoli wrote: > > Document in detail the new refcounted bridges as well as the "legacy" way. > > > > Signed-off-by: Luca Ceresoli > > > > --- ... > > + * Allocation, initializion and

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2024-12-31 Thread Randy Dunlap
Hi-- On 12/31/24 2:39 AM, Luca Ceresoli wrote: > Document in detail the new refcounted bridges as well as the "legacy" way. > > Signed-off-by: Luca Ceresoli > > --- > > This patch was added in v5. > --- > Documentation/gpu/drm-kms-helpers.rst | 6 ++ > drivers/gpu/drm/drm_bridge.c

[PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2024-12-31 Thread Luca Ceresoli
Document in detail the new refcounted bridges as well as the "legacy" way. Signed-off-by: Luca Ceresoli --- This patch was added in v5. --- Documentation/gpu/drm-kms-helpers.rst | 6 ++ drivers/gpu/drm/drm_bridge.c | 122 ++ 2 files changed, 128 inser