Re: [PATCH v5 01/11] drm: Add atomic variants of enable/disable to encoder helper funcs

2019-06-11 Thread Sean Paul
On Tue, Jun 11, 2019 at 08:53:52PM +0200, Sam Ravnborg wrote: > Hi Sean. > > Nits below. > > > > > + /** > > +* @atomic_disable: > > +* > ... > > +* > > +* This callback is a variant of @disable that provides the atomic state > > +* to the driver. It takes priority over @d

Re: [PATCH v5 01/11] drm: Add atomic variants of enable/disable to encoder helper funcs

2019-06-11 Thread Sam Ravnborg
Hi Sean. Nits below. > > + /** > + * @atomic_disable: > + * ... > + * > + * This callback is a variant of @disable that provides the atomic state > + * to the driver. It takes priority over @disable during atomic commits. > + * > + * This hook is used only

[PATCH v5 01/11] drm: Add atomic variants of enable/disable to encoder helper funcs

2019-06-11 Thread Sean Paul
From: Sean Paul This patch adds atomic_enable and atomic_disable callbacks to the encoder helpers. This will allow encoders to make informed decisions in their start-up/shutdown based on the committed state. Aside from the new hooks, this patch also introduces the new signature for .atomic_* fun