Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-03-15 Thread Pavel Machek
Hi! > > Comments from previous review were not addressed. > > > > Most importantly, this is not a way to do kernel interface. We want > > reasonable interface that can be documented and modified as needed. We > > want to pass /dev/input to userspace, not raw HID. This is not ok. > > There are al

Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-02-21 Thread Werner Sembach
Hi, Am 06.02.25 um 17:18 schrieb Werner Sembach: Hi, Am 01.02.25 um 09:48 schrieb Pavel Machek: Hi! I now got my feet a little wet with hid-bpf regarding something else, and with that knowledge I would leave the long arrays in the beginning in the kernel code for the time being: sirius_16_a

Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-02-07 Thread Werner Sembach
Hi, Am 01.02.25 um 09:48 schrieb Pavel Machek: Hi! I now got my feet a little wet with hid-bpf regarding something else, and with that knowledge I would leave the long arrays in the beginning in the kernel code for the time being: sirius_16_ansii_kbl_mapping and sirius_16_iso_kbl_mapping are

Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-02-03 Thread Werner Sembach
Am 01.02.25 um 05:39 schrieb Armin Wolf: Am 21.01.25 um 23:31 schrieb Werner Sembach: Hi, after some other work, picked this up again. Only coding style changes vs v4. I now got my feet a little wet with hid-bpf regarding something else, and with that knowledge I would leave the long arrays

Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-02-01 Thread Pavel Machek
Hi! > > I now got my feet a little wet with hid-bpf regarding something else, and > > with that knowledge I would leave the long arrays in the beginning in the > > kernel code for the time being: > > > > sirius_16_ansii_kbl_mapping and sirius_16_iso_kbl_mapping are required > > during initializat

Re: [PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-01-31 Thread Armin Wolf
Am 21.01.25 um 23:31 schrieb Werner Sembach: Hi, after some other work, picked this up again. Only coding style changes vs v4. I now got my feet a little wet with hid-bpf regarding something else, and with that knowledge I would leave the long arrays in the beginning in the kernel code for the

[PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-01-21 Thread Werner Sembach
Hi, after some other work, picked this up again. Only coding style changes vs v4. I now got my feet a little wet with hid-bpf regarding something else, and with that knowledge I would leave the long arrays in the beginning in the kernel code for the time being: sirius_16_ansii_kbl_mapping and si