Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Danilo Krummrich
On Thu Jun 26, 2025 at 6:23 PM CEST, Beata Michalska wrote: > With the Opaque, the expectations are that Rust should not > make any assumptions on the layout or invariants of the wrapped > C types. That runs rather counter to ioctl arguments, which must > adhere to certain data-layout constraints.

Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Daniel Almeida
> On 26 Jun 2025, at 13:23, Beata Michalska wrote: > > With the Opaque, the expectations are that Rust should not > make any assumptions on the layout or invariants of the wrapped > C types. That runs rather counter to ioctl arguments, which must > adhere to certain data-layout constraints. By

Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Daniel Almeida
> On 21 Jul 2025, at 12:33, Danilo Krummrich wrote: > > On Thu Jun 26, 2025 at 6:23 PM CEST, Beata Michalska wrote: >> With the Opaque, the expectations are that Rust should not >> make any assumptions on the layout or invariants of the wrapped >> C types. That runs rather counter to ioctl arg

Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Danilo Krummrich
On Thu Jun 26, 2025 at 6:23 PM CEST, Beata Michalska wrote: > With the Opaque, the expectations are that Rust should not > make any assumptions on the layout or invariants of the wrapped > C types. That runs rather counter to ioctl arguments, which must > adhere to certain data-layout constraints.

Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Daniel Almeida
Hi Danilo, > > Yeah, I can pick it up, but it won't be considered for the upcoming merge > window > anymore, but for the next. After -rc6 drm-misc is in feature freeze and I also > already send the PR for Nova. > > Daniel, Beata: Is there a reason you need this earlier? IIUC, this will be merg

Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Danilo Krummrich
On 7/21/25 4:55 PM, Alice Ryhl wrote: On Thu, Jun 26, 2025 at 06:23:13PM +0200, Beata Michalska wrote: With the Opaque, the expectations are that Rust should not make any assumptions on the layout or invariants of the wrapped C types. That runs rather counter to ioctl arguments, which must adher

Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-07-21 Thread Alice Ryhl
On Thu, Jun 26, 2025 at 06:23:13PM +0200, Beata Michalska wrote: > With the Opaque, the expectations are that Rust should not > make any assumptions on the layout or invariants of the wrapped > C types. That runs rather counter to ioctl arguments, which must > adhere to certain data-layout constrai

[PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

2025-06-26 Thread Beata Michalska
With the Opaque, the expectations are that Rust should not make any assumptions on the layout or invariants of the wrapped C types. That runs rather counter to ioctl arguments, which must adhere to certain data-layout constraints. By using Opaque, ioctl handlers are forced to use unsafe code where