Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Doug Anderson
Hi, On Thu, Jun 10, 2021 at 4:01 PM Linus Walleij wrote: > > On Fri, Jun 11, 2021 at 12:42 AM Doug Anderson wrote: > > On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij > > wrote: > > > > > #define mipi_dbi_command(dbi, cmd, seq...) \ > > > ({ \ > > > const u8 d[] = { seq }; \ > > >

Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
On Fri, Jun 11, 2021 at 12:42 AM Doug Anderson wrote: > On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij > wrote: > > #define mipi_dbi_command(dbi, cmd, seq...) \ > > ({ \ > > const u8 d[] = { seq }; \ > > mipi_dbi_command_stackbuf(dbi, cmd, d, ARRAY_SIZE(d)); \ > > }) > > > > I'l

Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Doug Anderson
Hi, On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij wrote: > > On Fri, Jun 11, 2021 at 12:30 AM Doug Anderson wrote: > > > > + mipi_dbi_command(dbi, MIPI_DCS_SET_ADDRESS_MODE, 0x0a); > > > > I would still prefer it if there was some type of error checking since > > SPI commands can fail and

Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
On Fri, Jun 11, 2021 at 12:30 AM Doug Anderson wrote: > > + mipi_dbi_command(dbi, MIPI_DCS_SET_ADDRESS_MODE, 0x0a); > > I would still prefer it if there was some type of error checking since > SPI commands can fail and could potentially fail silently. What about > at least this (untested):

Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Doug Anderson
Hi, On Thu, Jun 10, 2021 at 3:07 PM Linus Walleij wrote: > > @@ -0,0 +1,347 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Panel driver for the Samsung LMS397KF04 480x800 DPI RGB panel. > + * According to the data sheet the display controller is called DB7430. > + * Found in the Samsung Ga

[PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
This adds a new driver for the Samsung DB7430 DPI display controller as controlled over SPI. Right now the only panel product we know that is using this display controller is the LMS397KF04 but there may be more. This is the first regular panel driver making use of the MIPI DBI helper library. Th