Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-11 Thread Laurent Pinchart
Hi Daniel, On Thursday, 11 January 2018 10:19:50 EET Daniel Vetter wrote: > On Wed, Jan 10, 2018 at 06:28:51PM +0200, Peter Ujfalusi wrote: > > On 01/09/2018 04:40 PM, Daniel Vetter wrote: > >> On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote: > >>> On 2018-01-09 14:44, Daniel Vetter

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-11 Thread Daniel Vetter
On Wed, Jan 10, 2018 at 06:28:51PM +0200, Peter Ujfalusi wrote: > On 01/09/2018 04:40 PM, Daniel Vetter wrote: > > On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote: > >> Hi, > >> > >> On 2018-01-09 14:44, Daniel Vetter wrote: > Changes since v4: > - further simplify the zpos

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-10 Thread Peter Ujfalusi
On 01/09/2018 04:40 PM, Daniel Vetter wrote: > On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote: >> Hi, >> >> On 2018-01-09 14:44, Daniel Vetter wrote: Changes since v4: - further simplify the zpos checking by using a mask and a single loop - Commit message has been ext

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote: > Hi, > > On 2018-01-09 14:44, Daniel Vetter wrote: > >> Changes since v4: > >> - further simplify the zpos checking by using a mask and a single loop > >> - Commit message has been extended > >> > >> Changes since v3: > >> - Use drm_

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Peter Ujfalusi
Hi, On 2018-01-09 14:44, Daniel Vetter wrote: >> Changes since v4: >> - further simplify the zpos checking by using a mask and a single loop >> - Commit message has been extended >> >> Changes since v3: >> - Use drm_plane_index() instead of storing the same index wothin omap_plane >> struct >> -

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Tuesday, 9 January 2018 13:45:56 EET Peter Ujfalusi wrote: > Use the plane index as default zpos for all planes. Even if the > application is not setting zpos/zorder explicitly we will have unique zpos > for each plane. > > Planes with identical zpos value w

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 01:45:56PM +0200, Peter Ujfalusi wrote: > Use the plane index as default zpos for all planes. Even if the > application is not setting zpos/zorder explicitly we will have unique zpos > for each plane. > > Planes with identical zpos value will result undefined behavior: > di

[PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Peter Ujfalusi
Use the plane index as default zpos for all planes. Even if the application is not setting zpos/zorder explicitly we will have unique zpos for each plane. Planes with identical zpos value will result undefined behavior: disappearing planes, screen flickering and it is not supported by the hardware