Re: [PATCH v5] drm/fourcc: document modifier uniqueness requirements

2020-06-24 Thread Simon Ser
> > The new paragraph below looks good, but this sentence from the end of > > the paragraph above still needs to be removed: > > An example is AFBC, where both ARGB and ABGR have the exact same compressed > > layout. > > I think that entire paragraph was meant to be deleted, the replacement > is t

Re: [PATCH v5] drm/fourcc: document modifier uniqueness requirements

2020-06-24 Thread Daniel Vetter
On Wed, Jun 24, 2020 at 1:08 PM Brian Starkey wrote: > > Hi, > > On Tue, Jun 23, 2020 at 03:25:08PM +, Simon Ser wrote: > > There have suggestions to bake pitch alignment, address alignement, > > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) > > constraints into modifiers. L

Re: [PATCH v5] drm/fourcc: document modifier uniqueness requirements

2020-06-24 Thread Brian Starkey
Hi, On Tue, Jun 23, 2020 at 03:25:08PM +, Simon Ser wrote: > There have suggestions to bake pitch alignment, address alignement, > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) > constraints into modifiers. Last time this was brought up it seemed > like the consensus was to

[PATCH v5] drm/fourcc: document modifier uniqueness requirements

2020-06-23 Thread Simon Ser
There have suggestions to bake pitch alignment, address alignement, contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) constraints into modifiers. Last time this was brought up it seemed like the consensus was to not allow this. Document this in drm_fourcc.h. There are several reason