[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-02-02 Thread Marek Szyprowski
Hello, On 2015-01-22 14:00, Fabio Estevam wrote: > On Tue, Jan 20, 2015 at 10:16 AM, Marek Szyprowski > wrote: > >> + mixer_res->hdmi = devm_clk_get(dev, "hdmi"); >> + if (IS_ERR(mixer_res->hdmi)) { >> + dev_err(dev, "failed to get clock 'hdmi'\n"); >> + re

[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-22 Thread Marek Szyprowski
Hello, On 2015-01-22 13:51, Javier Martinez Canillas wrote: > Hello Marek, > > On 01/22/2015 01:41 PM, Marek Szyprowski wrote: + mixer_res->hdmi = devm_clk_get(dev, "hdmi"); >>> You need to update the >>> Documentation/devicetree/bindings/video/exynos_mixer.txt >>> DT binding docs

[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-22 Thread Javier Martinez Canillas
Hello Marek, On 01/22/2015 01:41 PM, Marek Szyprowski wrote: >>> >>> + mixer_res->hdmi = devm_clk_get(dev, "hdmi"); >> You need to update the >> Documentation/devicetree/bindings/video/exynos_mixer.txt >> DT binding docs to also mention the "hdmi" clock in the list of clocks. > > Right, I'v

[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-22 Thread Marek Szyprowski
Hello, On 2015-01-20 13:52, Javier Martinez Canillas wrote: > On 01/20/2015 01:16 PM, Marek Szyprowski wrote: >> Mixed need to have hdmi clock enabled to properly perform power on/off >> sequences, so add handling of this clock directly to the mixer driver. >> Dependency between hdmi clock and mix

[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-22 Thread Fabio Estevam
On Tue, Jan 20, 2015 at 10:16 AM, Marek Szyprowski wrote: > + mixer_res->hdmi = devm_clk_get(dev, "hdmi"); > + if (IS_ERR(mixer_res->hdmi)) { > + dev_err(dev, "failed to get clock 'hdmi'\n"); > + return -ENODEV; 'return PTR_ERR(mixer_res->hdmi);' would be

[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2015 01:16 PM, Marek Szyprowski wrote: > Mixed need to have hdmi clock enabled to properly perform power on/off > sequences, so add handling of this clock directly to the mixer driver. > Dependency between hdmi clock and mixer module has been observed on > Exynos4 based board

[PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-20 Thread Marek Szyprowski
Mixed need to have hdmi clock enabled to properly perform power on/off sequences, so add handling of this clock directly to the mixer driver. Dependency between hdmi clock and mixer module has been observed on Exynos4 based boards. Suggested-by: Andrzej Hajda Signed-off-by: Marek Szyprowski ---