Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen > --- I'm fine with or without removal of the variables: Reviewed-by: Sebastian Reiche

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen With Sam's comments addressed, Reviewed-by: Laurent Pin

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-11-24 Thread Tomi Valkeinen
On 24/11/2020 19:30, Sam Ravnborg wrote: > On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: >> Set the column & page address once during setup, instead of relying the >> DSI host driver to set those. >> >> Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > > But one comme

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-11-24 Thread Sam Ravnborg
On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Sam Ravnborg But one comment below. > --- > drivers/gpu/drm/panel/panel-dsi-

[PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-11-24 Thread Tomi Valkeinen
Set the column & page address once during setup, instead of relying the DSI host driver to set those. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-dsi-cm.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drive