Re: [PATCH v4 58/80] drm/omap: pll: fix iteration loop check

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:16PM +0200, Tomi Valkeinen wrote: > If the PLL calc function is given bad parameters, n_start/m_start may be > higher than n_stop/m_stop, which leads to the loops iterating through > the whole u32 number space. > > Fix this by failing early on such cases. > > Si

Re: [PATCH v4 58/80] drm/omap: pll: fix iteration loop check

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:16PM +0200, Tomi Valkeinen wrote: > If the PLL calc function is given bad parameters, n_start/m_start may be > higher than n_stop/m_stop, which leads to the loops iterating through > the whole u32 number space. > > Fix this by faili

[PATCH v4 58/80] drm/omap: pll: fix iteration loop check

2020-11-24 Thread Tomi Valkeinen
If the PLL calc function is given bad parameters, n_start/m_start may be higher than n_stop/m_stop, which leads to the loops iterating through the whole u32 number space. Fix this by failing early on such cases. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/pll.c | 6 ++ 1 f