Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Sharma, Shashank
Think about two situations where:- - Monitor supports scrambling and scdc, but we will not enable it, as the current mode is 1080P@148 MHz - Monitor supports scrambling and scdc, and we will enable it, as the current mode is 4k@596 Mhz To differentiate between these two, we have: config->hdmi_s

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Ville Syrjälä
On Thu, Feb 23, 2017 at 03:07:40PM +0200, Ander Conselvan De Oliveira wrote: > On Thu, 2017-02-23 at 16:33 +0530, Sharma, Shashank wrote: > > Thanks for the review Ander, my comments, inline. > > > > > > Regards > > > > Shashank > > > > > > On 2/23/2017 1:33 PM, Ander Conselvan De Oliveira wro

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Ander Conselvan De Oliveira
On Thu, 2017-02-23 at 16:33 +0530, Sharma, Shashank wrote: > Thanks for the review Ander, my comments, inline. > > > Regards > > Shashank > > > On 2/23/2017 1:33 PM, Ander Conselvan De Oliveira wrote: > > On Thu, 2017-02-23 at 10:01 +0530, Sharma, Shashank wrote: > > > Regards > > > > > > Sha

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Sharma, Shashank
Thanks for the review Ander, my comments, inline. Regards Shashank On 2/23/2017 1:33 PM, Ander Conselvan De Oliveira wrote: On Thu, 2017-02-23 at 10:01 +0530, Sharma, Shashank wrote: Regards Shashank On 2/22/2017 10:59 PM, Ville Syrjälä wrote: On Wed, Feb 22, 2017 at 06:48:30PM +0530, S

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Ander Conselvan De Oliveira
On Thu, 2017-02-23 at 10:01 +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 2/22/2017 10:59 PM, Ville Syrjälä wrote: > > On Wed, Feb 22, 2017 at 06:48:30PM +0530, Shashank Sharma wrote: > > > Geminilake platform sports a native HDMI 2.0 controller, and is > > > capable of driving

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-22 Thread Sharma, Shashank
Regards Shashank On 2/22/2017 10:59 PM, Ville Syrjälä wrote: On Wed, Feb 22, 2017 at 06:48:30PM +0530, Shashank Sharma wrote: Geminilake platform sports a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec mendates scrambling for these higher clocks,

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-22 Thread Ville Syrjälä
On Wed, Feb 22, 2017 at 06:48:30PM +0530, Shashank Sharma wrote: > Geminilake platform sports a native HDMI 2.0 controller, and is > capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec > mendates scrambling for these higher clocks, for reduced RF footprint. > > This patch checks if the moni

[PATCH v4 5/6] drm/i915: enable scrambling

2017-02-22 Thread Shashank Sharma
Geminilake platform sports a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec mendates scrambling for these higher clocks, for reduced RF footprint. This patch checks if the monitor supports scrambling, and if required, enables it during the modeset. V