Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 09:59:09AM -0700, Rob Clark wrote: > On Thu, Oct 29, 2020 at 9:14 AM Daniel Vetter wrote: > > > > On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > > > > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Sta

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Rob Clark
On Thu, Oct 29, 2020 at 9:14 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach > > > wrote: > > > > > > > > On Fr, 2020-10-23 at 09:51 -0700, Rob

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Daniel Vetter
On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach wrote: > > > > > > On Fr, 2020-10-23 at 09:51 -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > If there is only a s

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-26 Thread Daniel Vetter
On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach wrote: > > > > On Fr, 2020-10-23 at 09:51 -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > If there is only a single ring (no-preemption), everything is FIFO order > > > and there is

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-23 Thread Rob Clark
On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach wrote: > > On Fr, 2020-10-23 at 09:51 -0700, Rob Clark wrote: > > From: Rob Clark > > > > If there is only a single ring (no-preemption), everything is FIFO order > > and there is no need to implicit-sync. > > > > Mesa should probably just always use M

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-23 Thread Lucas Stach
On Fr, 2020-10-23 at 09:51 -0700, Rob Clark wrote: > From: Rob Clark > > If there is only a single ring (no-preemption), everything is FIFO order > and there is no need to implicit-sync. > > Mesa should probably just always use MSM_SUBMIT_NO_IMPLICIT, as behavior > is undefined when fences are n

[PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-23 Thread Rob Clark
From: Rob Clark If there is only a single ring (no-preemption), everything is FIFO order and there is no need to implicit-sync. Mesa should probably just always use MSM_SUBMIT_NO_IMPLICIT, as behavior is undefined when fences are not used to synchronize buffer usage across contexts (which is the