Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-18 Thread Matt Roper
On Tue, Jul 18, 2023 at 02:28:26AM +0200, Andi Shyti wrote: > Hi Matt, > > > > > > > + /* > > > > > > +* Aux invalidations on Aux CCS platforms require > > > > > > +* memory traffic is quiesced prior. > > > > > > +*/ > > > > > > + if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engin

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Andi Shyti
Hi Matt, > > > > > + /* > > > > > + * Aux invalidations on Aux CCS platforms require > > > > > + * memory traffic is quiesced prior. > > > > > + */ > > > > > + if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915)) > > > > > > > > It's a pre-existing mistake in drm-ti

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Matt Roper
On Mon, Jul 17, 2023 at 11:52:25PM +0200, Andi Shyti wrote: > Hi Matt, > > On Mon, Jul 17, 2023 at 01:31:03PM -0700, Matt Roper wrote: > > On Mon, Jul 17, 2023 at 10:54:37AM -0700, Matt Roper wrote: > > > On Mon, Jul 17, 2023 at 07:30:55PM +0200, Andi Shyti wrote: > > > > From: Jonathan Cavitt >

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Andi Shyti
Hi Matt, On Mon, Jul 17, 2023 at 01:31:03PM -0700, Matt Roper wrote: > On Mon, Jul 17, 2023 at 10:54:37AM -0700, Matt Roper wrote: > > On Mon, Jul 17, 2023 at 07:30:55PM +0200, Andi Shyti wrote: > > > From: Jonathan Cavitt > > > > > > All memory traffic must be quiesced before requesting > > > a

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Matt Roper
On Mon, Jul 17, 2023 at 10:54:37AM -0700, Matt Roper wrote: > On Mon, Jul 17, 2023 at 07:30:55PM +0200, Andi Shyti wrote: > > From: Jonathan Cavitt > > > > All memory traffic must be quiesced before requesting > > an aux invalidation on platforms that use Aux CCS. > > > > Fixes: 972282c4cf24 ("d

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Matt Roper
On Mon, Jul 17, 2023 at 07:30:55PM +0200, Andi Shyti wrote: > From: Jonathan Cavitt > > All memory traffic must be quiesced before requesting > an aux invalidation on platforms that use Aux CCS. > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all > engines") > Signed-off-

[PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu