Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-21 Thread Doug Anderson
Hi, On Sun, Jul 20, 2025 at 4:19 AM Diogo Ivo wrote: > > On 7/20/25 8:50 AM, Brigham Campbell wrote: > > On Sat Jul 19, 2025 at 11:10 AM MDT, Diogo Ivo wrote: > >>> nit: can just be this: > >>> > >>> struct mipi_dsi_multi_context dsi_ctx = {}; > >> > >> I am not an expert here but I was under the

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-20 Thread Diogo Ivo
On 7/20/25 8:50 AM, Brigham Campbell wrote: On Sat Jul 19, 2025 at 11:10 AM MDT, Diogo Ivo wrote: nit: can just be this: struct mipi_dsi_multi_context dsi_ctx = {}; I am not an expert here but I was under the impression that this is only valid with C23 while the kernel is written in C11. I

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-20 Thread Brigham Campbell
On Sat Jul 19, 2025 at 11:10 AM MDT, Diogo Ivo wrote: >> nit: can just be this: >> >> struct mipi_dsi_multi_context dsi_ctx = {}; > > I am not an expert here but I was under the impression that this is only > valid with C23 while the kernel is written in C11. Is there something I > am missing? > >

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-19 Thread Diogo Ivo
On 7/18/25 5:11 PM, Doug Anderson wrote: Hi, On Thu, Jul 17, 2025 at 9:41 AM Brigham Campbell wrote: static int jdi_panel_prepare(struct drm_panel *panel) { struct jdi_panel *jdi = to_panel_jdi(panel); + struct mipi_dsi_multi_context dsi_ctx = { .accum_err = 0 }; nit:

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-18 Thread Doug Anderson
Hi, On Thu, Jul 17, 2025 at 9:41 AM Brigham Campbell wrote: > > static int jdi_panel_prepare(struct drm_panel *panel) > { > struct jdi_panel *jdi = to_panel_jdi(panel); > + struct mipi_dsi_multi_context dsi_ctx = { .accum_err = 0 }; nit: can just be this: struct mipi_dsi_multi_

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-18 Thread Diogo Ivo
On 7/17/25 5:40 PM, Brigham Campbell wrote: Fix bug in unprepare() which causes the function's return value to be that of the last mipi "enter sleep mode" command. Update driver to use the "multi" variant of MIPI functions in order to facilitate improved error handling and remove the panel's

[PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-17 Thread Brigham Campbell
Fix bug in unprepare() which causes the function's return value to be that of the last mipi "enter sleep mode" command. Update driver to use the "multi" variant of MIPI functions in order to facilitate improved error handling and remove the panel's dependency on deprecated MIPI functions. Use the