Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-06-06 Thread Jani Nikula
On Fri, 06 Jun 2025, Maxime Ripard wrote: > Thanks for working on that. Your two patches (the one you sent here, and > the one in the other subthread) look good to me. So if that works, it > looks like we have a way forward. Coincidentally, I just posted the first non-draft patches [1]. Thanks fo

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-06-06 Thread Maxime Ripard
On Tue, May 27, 2025 at 10:40:49PM +0300, Jani Nikula wrote: > On Tue, 27 May 2025, Maxime Ripard wrote: > > On Tue, May 20, 2025 at 01:09:47PM +0300, Jani Nikula wrote: > >> > >> Maxime - > >> > >> I'm cutting a lot of context here. Not because I don't think it deserves > >> an answer, but beca

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Jani Nikula
On Tue, 27 May 2025, Maxime Ripard wrote: > On Tue, May 20, 2025 at 01:09:47PM +0300, Jani Nikula wrote: >> >> Maxime - >> >> I'm cutting a lot of context here. Not because I don't think it deserves >> an answer, but because I seem to be failing at communication. >> >> On Mon, 19 May 2025, Maxi

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Jani Nikula
On Tue, 27 May 2025, Maxime Ripard wrote: > Hi, > > On Fri, May 23, 2025 at 02:34:05PM +0300, Jani Nikula wrote: >> On Tue, 20 May 2025, Jani Nikula wrote: >> > Maxime - >> > >> > I'm cutting a lot of context here. Not because I don't think it deserves >> > an answer, but because I seem to be fai

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Maxime Ripard
Hi, On Fri, May 23, 2025 at 02:34:05PM +0300, Jani Nikula wrote: > On Tue, 20 May 2025, Jani Nikula wrote: > > Maxime - > > > > I'm cutting a lot of context here. Not because I don't think it deserves > > an answer, but because I seem to be failing at communication. > > > > On Mon, 19 May 2025, M

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-27 Thread Maxime Ripard
On Tue, May 20, 2025 at 01:09:47PM +0300, Jani Nikula wrote: > > Maxime - > > I'm cutting a lot of context here. Not because I don't think it deserves > an answer, but because I seem to be failing at communication. > > On Mon, 19 May 2025, Maxime Ripard wrote: > > You still haven't explained wh

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-23 Thread Jani Nikula
On Tue, 20 May 2025, Jani Nikula wrote: > Maxime - > > I'm cutting a lot of context here. Not because I don't think it deserves > an answer, but because I seem to be failing at communication. > > On Mon, 19 May 2025, Maxime Ripard wrote: >> You still haven't explained why it would take anything m

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-20 Thread Jani Nikula
Maxime - I'm cutting a lot of context here. Not because I don't think it deserves an answer, but because I seem to be failing at communication. On Mon, 19 May 2025, Maxime Ripard wrote: > You still haven't explained why it would take anything more than > registering a dumb device at probe time

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-19 Thread Maxime Ripard
On Wed, May 14, 2025 at 12:22:40PM +0300, Jani Nikula wrote: > On Tue, 13 May 2025, Maxime Ripard wrote: > > Is it really surprising you get some pushback when you are using a > > design that is the complete opposite to what every user of it for the > > last decade has been doing? > > The opposit

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-19 Thread Jani Nikula
On Fri, 16 May 2025, Anusha Srivatsa wrote: > On Wed, May 14, 2025 at 5:22 AM Jani Nikula > wrote: > >> On Tue, 13 May 2025, Maxime Ripard wrote: >> > Is it really surprising you get some pushback when you are using a >> > design that is the complete opposite to what every user of it for the >>

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-16 Thread Anusha Srivatsa
On Wed, May 14, 2025 at 5:22 AM Jani Nikula wrote: > On Tue, 13 May 2025, Maxime Ripard wrote: > > Is it really surprising you get some pushback when you are using a > > design that is the complete opposite to what every user of it for the > > last decade has been doing? > > The opposite is also

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-14 Thread Jani Nikula
On Tue, 13 May 2025, Maxime Ripard wrote: > Is it really surprising you get some pushback when you are using a > design that is the complete opposite to what every user of it for the > last decade has been doing? The opposite is also true. If you create a design that does not cleanly fit the mod

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-13 Thread Maxime Ripard
On Fri, May 09, 2025 at 03:45:36PM +0300, Jani Nikula wrote: > On Fri, 09 May 2025, Maxime Ripard wrote: > > On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: > >> On Mon, 05 May 2025, Anusha Srivatsa wrote: > >> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > >> > > >> >> Hi

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-13 Thread Jani Nikula
On Mon, 12 May 2025, Anusha Srivatsa wrote: > I get that embedding drm_panel within intel_panel which is embedded > within intel_connector, which also embeds drm_connector and so on can > get confusing to use. But Jani, > about drm_panel_follower , which is the panel that is following the > intel_

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-12 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 8:45 AM Jani Nikula wrote: > On Fri, 09 May 2025, Maxime Ripard wrote: > > On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: > >> On Mon, 05 May 2025, Anusha Srivatsa wrote: > >> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard > wrote: > >> > > >> >> Hi Jani, >

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-09 Thread Jani Nikula
On Thu, 08 May 2025, Anusha Srivatsa wrote: > On Thu, May 8, 2025 at 10:27 AM Jani Nikula > wrote: > >> On Mon, 05 May 2025, Anusha Srivatsa wrote: >> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: >> > >> >> Hi Jani, >> >> >> >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrot

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-09 Thread Jani Nikula
On Fri, 09 May 2025, Maxime Ripard wrote: > On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: >> On Mon, 05 May 2025, Anusha Srivatsa wrote: >> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: >> > >> >> Hi Jani, >> >> >> >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula w

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-09 Thread Maxime Ripard
On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: > On Mon, 05 May 2025, Anusha Srivatsa wrote: > > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > > > >> Hi Jani, > >> > >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: > >> > On Tue, 29 Apr 2025, Maxime Ripard wr

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-08 Thread Anusha Srivatsa
On Thu, May 8, 2025 at 10:27 AM Jani Nikula wrote: > On Mon, 05 May 2025, Anusha Srivatsa wrote: > > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > > > >> Hi Jani, > >> > >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: > >> > On Tue, 29 Apr 2025, Maxime Ripard wrote: > >

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-08 Thread Jani Nikula
On Mon, 05 May 2025, Anusha Srivatsa wrote: > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > >> Hi Jani, >> >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: >> > On Tue, 29 Apr 2025, Maxime Ripard wrote: >> > > Hi Jani, >> > > >> > > On Mon, Apr 28, 2025 at 07:31:50PM +0300

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-05 Thread Anusha Srivatsa
On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > Hi Jani, > > On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: > > On Tue, 29 Apr 2025, Maxime Ripard wrote: > > > Hi Jani, > > > > > > On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote: > > >> On Mon, 31 Mar 2025, Anusha

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-04 Thread Maxime Ripard
Hi Jani, On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: > On Tue, 29 Apr 2025, Maxime Ripard wrote: > > Hi Jani, > > > > On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote: > >> On Mon, 31 Mar 2025, Anusha Srivatsa wrote: > >> > Allocate panel via reference counting. Add _

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-04-29 Thread Jani Nikula
On Tue, 29 Apr 2025, Maxime Ripard wrote: > Hi Jani, > > On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote: >> On Mon, 31 Mar 2025, Anusha Srivatsa wrote: >> > Allocate panel via reference counting. Add _get() and _put() helper >> > functions to ensure panel allocations are refcounted.

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-04-29 Thread Maxime Ripard
Hi Jani, On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote: > On Mon, 31 Mar 2025, Anusha Srivatsa wrote: > > Allocate panel via reference counting. Add _get() and _put() helper > > functions to ensure panel allocations are refcounted. Avoid use after > > free by ensuring panel pointer

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-04-28 Thread Jani Nikula
On Mon, 31 Mar 2025, Anusha Srivatsa wrote: > Allocate panel via reference counting. Add _get() and _put() helper > functions to ensure panel allocations are refcounted. Avoid use after > free by ensuring panel pointer is valid and can be usable till the last > reference is put. > > Reviewed-by: L

[PATCH v4 2/4] drm/panel: Add refcount support

2025-03-31 Thread Anusha Srivatsa
Allocate panel via reference counting. Add _get() and _put() helper functions to ensure panel allocations are refcounted. Avoid use after free by ensuring panel pointer is valid and can be usable till the last reference is put. Reviewed-by: Luca Ceresoli Reviewed-by: Maxime Ripard Signed-off-by: