Re: [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-06-15 Thread Peter Vasil
On Mon, May 8, 2023 at 11:21 PM Linus Walleij wrote: > > A recent change to the OMAP driver making it use a dynamic GPIO > base created problems with some old OMAP1 board files, among > them Nokia 770, SX1 and also the OMAP2 Nokia n8x0. > > Fix up all instances of GPIOs being used for the MMC driv

Re: [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-06-14 Thread Linus Walleij
On Wed, Jun 14, 2023 at 10:44 AM Peter Vasil wrote: > On Mon, May 8, 2023 at 11:21 PM Linus Walleij > wrote: > > +static struct gpiod_lookup_table nokia810_mmc_gpio_table = { > > + .dev_id = "mmci-omap", > > + .table = { > > + /* Slot index 1, VSD power, GPIO 23 */ > >

Re: [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-05-17 Thread Linus Walleij
On Wed, May 17, 2023 at 10:30 PM Aaro Koskinen wrote: > This one has some issue as mmci-omap is unable to find the GPIOs on 770. > > On Mon, May 08, 2023 at 11:20:07PM +0200, Linus Walleij wrote: > > +static struct gpiod_lookup_table nokia770_mmc_gpio_table = { > > + .dev_id = "mmci-omap", >

Re: [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-05-17 Thread Aaro Koskinen
Hi, This one has some issue as mmci-omap is unable to find the GPIOs on 770. On Mon, May 08, 2023 at 11:20:07PM +0200, Linus Walleij wrote: > +static struct gpiod_lookup_table nokia770_mmc_gpio_table = { > + .dev_id = "mmci-omap", Changing this to "mmci-omap.1" helped, not sure if that is a

[PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-05-08 Thread Linus Walleij
A recent change to the OMAP driver making it use a dynamic GPIO base created problems with some old OMAP1 board files, among them Nokia 770, SX1 and also the OMAP2 Nokia n8x0. Fix up all instances of GPIOs being used for the MMC driver by pushing the handling of power, slot selection and MMC "cove