Re: [PATCH v4 2/3] drm: Add support for the LogiCVC display controller

2020-04-03 Thread Paul Kocialkowski
Hi Sam, On Sat 04 Jan 20, 20:20, Sam Ravnborg wrote: > Good looking driver. Well structured in a number of relevant files. > A few comments in the following. > Some parts I fail to follow - due to my lack of DRM knowledge. > So all in all - only trivial comments. Thanks for the review and the fri

Re: [PATCH v4 2/3] drm: Add support for the LogiCVC display controller

2020-01-04 Thread Sam Ravnborg
Hi Paul. Good looking driver. Well structured in a number of relevant files. A few comments in the following. Some parts I fail to follow - due to my lack of DRM knowledge. So all in all - only trivial comments. With these fixed you can add: Acked-by: Sam Ravnborg Sam On Tue, Dec 03, 2

[PATCH v4 2/3] drm: Add support for the LogiCVC display controller

2019-12-03 Thread Paul Kocialkowski
Introduces a driver for the LogiCVC display controller, a programmable logic controller optimized for use in Xilinx Zynq-7000 SoCs and other Xilinx FPGAs. The controller is mostly configured at logic synthesis time so only a subset of configuration is left for the driver to handle. The following f