Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-03 Thread Dmitry Osipenko
On 4/3/23 16:22, Emil Velikov wrote: > On Mon, 3 Apr 2023 at 14:00, Emil Velikov wrote: > I think we should zero num_(in|out)_syncobjs when the respective parse fails. Otherwise we get one "cleanup" within the parse function itself and a second during the cleanup_submit. Haven't lo

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-03 Thread Emil Velikov
On Mon, 3 Apr 2023 at 14:00, Emil Velikov wrote: > > > I think we should zero num_(in|out)_syncobjs when the respective parse > > > fails. Otherwise we get one "cleanup" within the parse function itself > > > and a second during the cleanup_submit. Haven't looked at it too closely > > > but I sus

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-03 Thread Emil Velikov
On Sun, 2 Apr 2023 at 18:45, Dmitry Osipenko wrote: > > On 3/30/23 20:24, Emil Velikov wrote: > > Hi Dmitry, > > > > Have you considered creating a few DRM helpers for this functionality? > > > > AFAICT this is the third driver which supports syncobj timelines and > > looking at one of the impleme

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-02 Thread Dmitry Osipenko
On 3/30/23 20:24, Emil Velikov wrote: > Hi Dmitry, > > Have you considered creating a few DRM helpers for this functionality? > > AFAICT this is the third driver which supports syncobj timelines and > looking at one of the implementations ... it is not great. Note that > this suggestion is _not_

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-03-30 Thread Emil Velikov
Hi Dmitry, Have you considered creating a few DRM helpers for this functionality? AFAICT this is the third driver which supports syncobj timelines and looking at one of the implementations ... it is not great. Note that this suggestion is _not_ a blocker. On 2023/03/24, Dmitry Osipenko wrote: >

[PATCH v4 2/2] drm/virtio: Support sync objects

2023-03-23 Thread Dmitry Osipenko
Add sync object DRM UAPI support to VirtIO-GPU driver. It's required for enabling a full-featured Vulkan fencing by Venus and native context VirtIO-GPU Mesa drivers. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/virtio/virtgpu_drv.c| 3 +- drivers/gpu/drm/virtio/virtgpu_submit.c | 219