Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-11 Thread Neil Armstrong
Le 10/03/2023 à 23:50, Linus Walleij a écrit : On Fri, Mar 10, 2023 at 7:35 PM Jianhua Lu wrote: On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote: +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...)\ + do {

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Linus Walleij
On Fri, Mar 10, 2023 at 7:35 PM Jianhua Lu wrote: > On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote: > > > > > +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...)\ > > > + do { \ > > > + mip

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote: > > > +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...)\ > > + do { \ > > + mipi_dsi_dcs_write_seq(dsi0, cmd, seq); \ > > +

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Konrad Dybcio
On 10.03.2023 14:21, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. > > Signed-off-by: Jianhua Lu > --- > Changes in v4: > - add multiple modes support > - use dev_err_probe helper > - fix dsi_info type string > - reimplement mipi_dsi_dual_dcs_

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 09:21:44PM +0800, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. ... > + > +static int nt36523_get_modes(struct drm_panel *panel, > +struct drm_connector *connector) > +{ > + struct panel_info *pinfo =

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Neil Armstrong
Hi, On 10/03/2023 14:21, Jianhua Lu wrote: Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v4: - add multiple modes support - use dev_err_probe helper - fix dsi_info type string - reimplement mipi_dsi_dual_dcs_write_seq(

[PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v4: - add multiple modes support - use dev_err_probe helper - fix dsi_info type string - reimplement mipi_dsi_dual_dcs_write_seq() macro Changes in v3: - Refactor source code