On Wed Jun 4, 2025 at 7:23 PM JST, Danilo Krummrich wrote:
> On Wed, May 21, 2025 at 03:45:12PM +0900, Alexandre Courbot wrote:
>> +impl Chipset {
>> +/// Returns the HAL corresponding to this chipset.
>> +pub(super) fn get_fb_fal(self) -> &'static dyn FbHal {
>
> Please don't use the 'get'
On Wed Jun 4, 2025 at 7:24 PM JST, Danilo Krummrich wrote:
> On Wed, Jun 04, 2025 at 01:18:37PM +0900, Alexandre Courbot wrote:
>> On Wed Jun 4, 2025 at 6:14 AM JST, Lyude Paul wrote:
>> > On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote:
>> >> +const NV_PRAMIN_SIZE: u64 =
On Wed, Jun 04, 2025 at 01:18:37PM +0900, Alexandre Courbot wrote:
> On Wed Jun 4, 2025 at 6:14 AM JST, Lyude Paul wrote:
> > On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote:
> >> +const NV_PRAMIN_SIZE: u64 = 0x10;
> >
> > Don't leave those size constants out, they're
On Wed, May 21, 2025 at 03:45:12PM +0900, Alexandre Courbot wrote:
> +impl Chipset {
> +/// Returns the HAL corresponding to this chipset.
> +pub(super) fn get_fb_fal(self) -> &'static dyn FbHal {
Please don't use the 'get' prefix here.
Also, I feel like it's a bit random to have this on
On Wed Jun 4, 2025 at 6:14 AM JST, Lyude Paul wrote:
> On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote:
>> FWSEC-FRTS is run with the desired address of the FRTS region as
>> parameter, which we need to compute depending on some hardware
>> parameters.
>>
>> Do this in a `FbLayout` stru
On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote:
> FWSEC-FRTS is run with the desired address of the FRTS region as
> parameter, which we need to compute depending on some hardware
> parameters.
>
> Do this in a `FbLayout` structure, that will be later extended to
> describe more memory
FWSEC-FRTS is run with the desired address of the FRTS region as
parameter, which we need to compute depending on some hardware
parameters.
Do this in a `FbLayout` structure, that will be later extended to
describe more memory regions used to boot the GSP.
Signed-off-by: Alexandre Courbot
---
d
