Re: [Intel-gfx] [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 12:05:39PM -0700, Niranjana Vishwanathapura wrote: On Thu, Oct 20, 2022 at 04:27:38PM +0200, Andi Shyti wrote: Hi Niranjana, [...] @@ -307,6 +307,8 @@ struct i915_vma { struct list_head non_priv_vm_bind_link; /* @vm_rebind_link: link to vm_rebind_list a

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 04:27:38PM +0200, Andi Shyti wrote: Hi Niranjana, [...] @@ -307,6 +307,8 @@ struct i915_vma { struct list_head non_priv_vm_bind_link; /* @vm_rebind_link: link to vm_rebind_list and protected by vm_rebind_lock */ struct list_head vm_rebind_link;

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 05:29:45PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->us

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list Signed-off-by: Niranjana Vishwanathapur

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Andi Shyti
Hi Niranjana, [...] > @@ -307,6 +307,8 @@ struct i915_vma { > struct list_head non_priv_vm_bind_link; > /* @vm_rebind_link: link to vm_rebind_list and protected by > vm_rebind_lock */ > struct list_head vm_rebind_link; /* Link in vm_rebind_list */ > + /*@userptr_invalidated

[PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-18 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/