[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-04-04 Thread Tomasz Stanislawski
Hi Inki, Sorry for a very late reply. On 02/19/2014 12:14 PM, Inki Dae wrote: > Hi Tomasz, > > > 2014-02-14 23:13 GMT+09:00 Tomasz Stanislawski : >> Hi Daniel, >> I think that it would be better to change the semantic of phy and ddc >> bindings. >> >> Rather than pointing to I2C client it should

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-19 Thread Inki Dae
2014-01-31 6:19 GMT+09:00 Sean Paul : > From: Daniel Kurtz > > The i2c client was previously being passed into the hdmi driver via a > dedicated i2c driver, and then a global variable. This patch removes all > of that and just uses the device tree to get the i2c_client. This patch > also properly

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-19 Thread Inki Dae
Hi Tomasz, 2014-02-14 23:13 GMT+09:00 Tomasz Stanislawski : > Hi Daniel, > I think that it would be better to change the semantic of phy and ddc > bindings. > > Rather than pointing to I2C client it should point to I2C bus instead. > The exynos DRM driver can create dummy I2C clients using i2c_ne

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-14 Thread Tomasz Stanislawski
Hi Daniel, I think that it would be better to change the semantic of phy and ddc bindings. Rather than pointing to I2C client it should point to I2C bus instead. The exynos DRM driver can create dummy I2C clients using i2c_new_dummy() function. There is quite strong rationale for this: - DDC is a

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-12 Thread Tomasz Figa
On 12.02.2014 00:02, Olof Johansson wrote: > On Fri, Feb 7, 2014 at 6:52 PM, Tomasz Figa wrote: > >> Adding new required properties to an already defined binding is breaking >> backwards compatibility, which is supposed to be preserved, since DT is an >> ABI. >> >> Now, I'm not really a big fan of

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-11 Thread Tomasz Figa
On 10.02.2014 08:30, Inki Dae wrote: > 2014-02-08 11:52 GMT+09:00 Tomasz Figa : >> Hi, >> >> >> On 30.01.2014 22:19, Sean Paul wrote: >>> >>> From: Daniel Kurtz >>> >>> The i2c client was previously being passed into the hdmi driver via a >>> dedicated i2c driver, and then a global variable. Thi

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-11 Thread Olof Johansson
On Fri, Feb 7, 2014 at 6:52 PM, Tomasz Figa wrote: > Adding new required properties to an already defined binding is breaking > backwards compatibility, which is supposed to be preserved, since DT is an > ABI. > > Now, I'm not really a big fan of DT stability, but if we decide to maintain > it fo

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-10 Thread Inki Dae
2014-02-08 11:52 GMT+09:00 Tomasz Figa : > Hi, > > > On 30.01.2014 22:19, Sean Paul wrote: >> >> From: Daniel Kurtz >> >> The i2c client was previously being passed into the hdmi driver via a >> dedicated i2c driver, and then a global variable. This patch removes all >> of that and just uses the d

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-08 Thread Tomasz Figa
Hi, On 30.01.2014 22:19, Sean Paul wrote: > From: Daniel Kurtz > > The i2c client was previously being passed into the hdmi driver via a > dedicated i2c driver, and then a global variable. This patch removes all > of that and just uses the device tree to get the i2c_client. This patch > also prop

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-01-30 Thread Sean Paul
From: Daniel Kurtz The i2c client was previously being passed into the hdmi driver via a dedicated i2c driver, and then a global variable. This patch removes all of that and just uses the device tree to get the i2c_client. This patch also properly references the client so we don't lose it before