Re: [PATCH v4 14/20] gpu: nova-core: add falcon register definitions and base code

2025-06-03 Thread Alexandre Courbot
Hi Lyude, thanks for the review! On Sat May 31, 2025 at 7:22 AM JST, Lyude Paul wrote: >> +/// `target_mem`. >> +/// >> +/// `sec` is set if the loaded firmware is expected to run in secure >> mode. >> +fn dma_wr( >> +&self, >> +bar: &Bar0, >> +dma_handle:

Re: [PATCH v4 14/20] gpu: nova-core: add falcon register definitions and base code

2025-06-03 Thread Alexandre Courbot
On Mon Jun 2, 2025 at 9:06 PM JST, Danilo Krummrich wrote: > On Wed, May 21, 2025 at 03:45:09PM +0900, Alexandre Courbot wrote: >> Add the common Falcon code and HAL for Ampere GPUs, and instantiate the >> GSP and SEC2 Falcons that will be required to boot the GSP. > > Maybe add a few more words ab

Re: [PATCH v4 14/20] gpu: nova-core: add falcon register definitions and base code

2025-06-02 Thread Danilo Krummrich
On Wed, May 21, 2025 at 03:45:09PM +0900, Alexandre Courbot wrote: > Add the common Falcon code and HAL for Ampere GPUs, and instantiate the > GSP and SEC2 Falcons that will be required to boot the GSP. Maybe add a few more words about the architectural approach taken here? > +/// Valid values fo

Re: [PATCH v4 14/20] gpu: nova-core: add falcon register definitions and base code

2025-05-30 Thread Lyude Paul
Some comments down below On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote: > Add the common Falcon code and HAL for Ampere GPUs, and instantiate the > GSP and SEC2 Falcons that will be required to boot the GSP. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/nova-core/falcon.

[PATCH v4 14/20] gpu: nova-core: add falcon register definitions and base code

2025-05-20 Thread Alexandre Courbot
Add the common Falcon code and HAL for Ampere GPUs, and instantiate the GSP and SEC2 Falcons that will be required to boot the GSP. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/falcon.rs | 560 ++ drivers/gpu/nova-core/falcon/gsp.rs | 22