Re: [PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion

2025-06-02 Thread Alexandre Courbot
On Sat May 31, 2025 at 11:37 PM JST, Danilo Krummrich wrote: > On Sat, May 31, 2025 at 04:09:29PM +0200, Miguel Ojeda wrote: >> On Fri, May 30, 2025 at 11:51 PM Lyude Paul wrote: >> > TBH - we should really add some safe bindings for sleeps instead of calling >> > this unsafely, I'd be happy to re

Re: [PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion

2025-05-31 Thread Miguel Ojeda
On Sat, May 31, 2025 at 4:37 PM Danilo Krummrich wrote: > > I agreed to take this code without waiting for those abstractions, but with a > TODO to fix things up once they land. That sounds good, yeah. Cheers, Miguel

Re: [PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion

2025-05-31 Thread Danilo Krummrich
On Sat, May 31, 2025 at 04:09:29PM +0200, Miguel Ojeda wrote: > On Fri, May 30, 2025 at 11:51 PM Lyude Paul wrote: > > TBH - we should really add some safe bindings for sleeps instead of calling > > this unsafely, I'd be happy to review them if you do > > In case it helps, there is: > > > h

Re: [PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion

2025-05-31 Thread Miguel Ojeda
On Fri, May 30, 2025 at 11:51 PM Lyude Paul wrote: > > JFYI: You can actually just say Result here, since () is the default type for > the kernel's Result type +1 > TBH - we should really add some safe bindings for sleeps instead of calling > this unsafely, I'd be happy to review them if you do

Re: [PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion

2025-05-30 Thread Lyude Paul
On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote: > Upon reset, the GPU executes the GFW (GPU Firmware) in order to > initialize its base parameters such as clocks. The driver must ensure > that this step is completed before using the hardware. > > Signed-off-by: Alexandre Courbot > ---

[PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion

2025-05-21 Thread Alexandre Courbot
Upon reset, the GPU executes the GFW (GPU Firmware) in order to initialize its base parameters such as clocks. The driver must ensure that this step is completed before using the hardware. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gfw.rs | 37 ++