Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-06-19 Thread Rob Clark
On Thu, Apr 28, 2022 at 11:20 AM Dmitry Osipenko wrote: > > 27.04.2022 18:03, Daniel Vetter wrote: > >> ... > @@ -172,6 +172,41 @@ struct drm_gem_object_funcs { > * This is optional but necessary for mmap support. > */ > const struct vm_operations_struct *vm

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-19 Thread Dmitry Osipenko
On 5/19/22 17:13, Daniel Vetter wrote: > On Thu, May 12, 2022 at 10:04:53PM +0300, Dmitry Osipenko wrote: >> On 5/12/22 20:04, Daniel Vetter wrote: >>> On Thu, 12 May 2022 at 13:36, Dmitry Osipenko >>> wrote: On 5/11/22 22:09, Daniel Vetter wrote: > On Wed, May 11, 2022 at 07:06:18PM

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-19 Thread Daniel Vetter
On Thu, May 12, 2022 at 10:04:53PM +0300, Dmitry Osipenko wrote: > On 5/12/22 20:04, Daniel Vetter wrote: > > On Thu, 12 May 2022 at 13:36, Dmitry Osipenko > > wrote: > >> > >> On 5/11/22 22:09, Daniel Vetter wrote: > >>> On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: > On 5

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-12 Thread Dmitry Osipenko
On 5/12/22 20:04, Daniel Vetter wrote: > On Thu, 12 May 2022 at 13:36, Dmitry Osipenko > wrote: >> >> On 5/11/22 22:09, Daniel Vetter wrote: >>> On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: On 5/11/22 16:09, Daniel Vetter wrote: > I'd like to ask you to reduce the

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-12 Thread Daniel Vetter
On Thu, 12 May 2022 at 13:36, Dmitry Osipenko wrote: > > On 5/11/22 22:09, Daniel Vetter wrote: > > On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: > >> On 5/11/22 16:09, Daniel Vetter wrote: > >>> I'd like to ask you to reduce the scope of the patchset and build the > >>>

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-12 Thread Dmitry Osipenko
On 5/11/22 22:09, Daniel Vetter wrote: > On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: >> On 5/11/22 16:09, Daniel Vetter wrote: >>> I'd like to ask you to reduce the scope of the patchset and build the >>> shrinker only for virtio-gpu. I know that I first suggested to bu

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-11 Thread Daniel Vetter
On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: > On 5/11/22 16:09, Daniel Vetter wrote: > > I'd like to ask you to reduce the scope of the patchset and build the > > shrinker only for virtio-gpu. I know that I first suggested to build > > upon shmem helpers, but it see

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-11 Thread Dmitry Osipenko
On 5/11/22 16:09, Daniel Vetter wrote: > I'd like to ask you to reduce the scope of the patchset and build the > shrinker only for virtio-gpu. I know that I first suggested to build > upon shmem helpers, but it seems that it's easier to do that in a later > patchset. The first

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-11 Thread Daniel Vetter
On Tue, May 10, 2022 at 04:47:52PM +0300, Dmitry Osipenko wrote: > On 5/9/22 16:49, Daniel Vetter wrote: > > On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: > >> On 5/5/22 11:34, Thomas Zimmermann wrote: > >>> Hi > >>> > >>> Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > Intr

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-10 Thread Dmitry Osipenko
On 5/9/22 16:49, Daniel Vetter wrote: > On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: >> On 5/5/22 11:34, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: Introduce a common DRM SHMEM shrinker. It allows to reduce code duplication am

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:34, Thomas Zimmermann wrote: > > Hi > > > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > >> Introduce a common DRM SHMEM shrinker. It allows to reduce code > >> duplication among DRM drivers that implement theirs ow

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-05 Thread Dmitry Osipenko
On 5/5/22 11:34, Thomas Zimmermann wrote: > Hi > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: >> Introduce a common DRM SHMEM shrinker. It allows to reduce code >> duplication among DRM drivers that implement theirs own shrinkers. >> This is initial version of the shrinker that covers basic nee

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-05 Thread Daniel Vetter
On Thu, May 05, 2022 at 10:34:02AM +0200, Thomas Zimmermann wrote: > Hi > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > > Introduce a common DRM SHMEM shrinker. It allows to reduce code > > duplication among DRM drivers that implement theirs own shrinkers. > > This is initial version of the sh

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-05 Thread Thomas Zimmermann
Hi Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: Introduce a common DRM SHMEM shrinker. It allows to reduce code duplication among DRM drivers that implement theirs own shrinkers. This is initial version of the shrinker that covers basic needs of GPU drivers, both purging and eviction of shmem o

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-04 Thread Daniel Vetter
On Thu, Apr 28, 2022 at 09:20:15PM +0300, Dmitry Osipenko wrote: > 27.04.2022 18:03, Daniel Vetter wrote: > >> ... > @@ -172,6 +172,41 @@ struct drm_gem_object_funcs { >    * This is optional but necessary for mmap support. >    */ >   const struct vm_operations_stru

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-04-28 Thread Dmitry Osipenko
27.04.2022 18:03, Daniel Vetter wrote: >> ... @@ -172,6 +172,41 @@ struct drm_gem_object_funcs {    * This is optional but necessary for mmap support.    */   const struct vm_operations_struct *vm_ops; + +    /** + * @purge: + * +

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-04-27 Thread Daniel Vetter
On Tue, Apr 19, 2022 at 11:40:41PM +0300, Dmitry Osipenko wrote: > On 4/19/22 10:22, Thomas Zimmermann wrote: > > Hi > > > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > >> Introduce a common DRM SHMEM shrinker. It allows to reduce code > >> duplication among DRM drivers that implement theirs o

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-04-19 Thread Dmitry Osipenko
On 4/19/22 10:22, Thomas Zimmermann wrote: > Hi > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: >> Introduce a common DRM SHMEM shrinker. It allows to reduce code >> duplication among DRM drivers that implement theirs own shrinkers. >> This is initial version of the shrinker that covers basic ne

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-04-19 Thread Thomas Zimmermann
Hi Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: Introduce a common DRM SHMEM shrinker. It allows to reduce code duplication among DRM drivers that implement theirs own shrinkers. This is initial version of the shrinker that covers basic needs of GPU drivers, both purging and eviction of shmem o

[PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-04-17 Thread Dmitry Osipenko
Introduce a common DRM SHMEM shrinker. It allows to reduce code duplication among DRM drivers that implement theirs own shrinkers. This is initial version of the shrinker that covers basic needs of GPU drivers, both purging and eviction of shmem objects are supported. This patch is based on a coup