Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-07-17 Thread Laurent Pinchart
Hi Kieran, On Tuesday, 17 July 2018 19:08:44 EEST Kieran Bingham wrote: > On 17/07/18 13:52, Laurent Pinchart wrote: > > On Monday, 16 July 2018 21:21:00 EEST Kieran Bingham wrote: > >> On 24/05/18 13:51, Laurent Pinchart wrote: > >>> On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: > >

Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-07-17 Thread Kieran Bingham
Hi Laurent, On 17/07/18 13:52, Laurent Pinchart wrote: > Hi Kieran, > > On Monday, 16 July 2018 21:21:00 EEST Kieran Bingham wrote: >> On 24/05/18 13:51, Laurent Pinchart wrote: >>> On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: Calculate the top and bottom fields for the interl

Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-07-17 Thread Kieran Bingham
Hi Laurent, >>> +static void vsp1_rpf_configure_autofld(struct vsp1_rwpf *rpf, >>> + struct vsp1_dl_ext_cmd *cmd) >>> +{ >>> + const struct v4l2_pix_format_mplane *format = &rpf->format; >>> + struct vsp1_extcmd_auto_fld_body *auto_fld = cmd->data; >>> + u3

Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-07-17 Thread Laurent Pinchart
Hi Kieran, On Monday, 16 July 2018 21:21:00 EEST Kieran Bingham wrote: > On 24/05/18 13:51, Laurent Pinchart wrote: > > On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: > >> Calculate the top and bottom fields for the interlaced frames and > >> utilise the extended display list command

Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-07-16 Thread Kieran Bingham
Hi Laurent, Some questions here too :) On 24/05/18 13:51, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: >> Calculate the top and bottom fields for the interlaced frames and >> utilise the extended display list c

Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-24 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: > Calculate the top and bottom fields for the interlaced frames and > utilise the extended display list command feature to implement the > auto-field operations. This allows the DU to update the VSP2 r

[PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham --- v3: