[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-25 Thread Daniel Vetter
On Thu, Sep 25, 2014 at 2:54 AM, Mark yao wrote: > Hi, Daniel > this version is old, newest is v5. and I remove uapi at v5. > you can see v5 patch at: > https://lkml.org/lkml/2014/9/23/1061 > thanks > > This version doesn't seem to be cc'ed to dri-devel, at least it didn't > yet show up. Can you p

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
On 2014?09?24? 19:20, Daniel Vetter wrote: > On Wed, Sep 24, 2014 at 11:31 AM, Mark yao wrote: >> On 2014?09?24? 16:20, Daniel Vetter wrote: >>> On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-of

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-24 Thread Mark yao
On 2014?09?24? 16:20, Daniel Vetter wrote: > On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-off-by: Mark yao >> --- >> Changes in v2: >> - use the component framework to defer main drm driver probe >>

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Vetter
On Wed, Sep 24, 2014 at 11:31 AM, Mark yao wrote: > On 2014?09?24? 16:20, Daniel Vetter wrote: >> >> On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: >>> >>> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >>> >>> Signed-off-by: Mark yao >>> --- >>> Changes in v2:

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Vetter
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all VOP devices have been probed. > - use

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?22? 23:54, Arnd Bergmann wrote: > On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote: + + /* TODO(djkurtz): fetch the mapping start/size from somewhere */ + mapping = arm_iommu_create_mapping(&platform_bus_type, 0x1000, +

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?22? 22:43, Arnd Bergmann wrote: > On Monday 22 September 2014 18:48:54 Mark yao wrote: >> diff --git a/drivers/gpu/drm/rockchip/Kconfig >> b/drivers/gpu/drm/rockchip/Kconfig >> new file mode 100644 >> index 000..7146c80 >> --- /dev/null >> +++ b/drivers/gpu/drm/rockchip/Kconfig >> @

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?23? 03:10, Rob Clark wrote: > Ok, couple more small comments.. this time I actually had time to go > through the entire patch, not just the uapi > > > On Mon, Sep 22, 2014 at 6:48 AM, Mark yao wrote: >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?22? 21:24, Boris BREZILLON wrote: > Hi Mark, > > You'll find some comments inline. > Anyway, I wouldn't call it a review (your driver is using some concepts > I'm not used to, like IOMMUs) but rather a collection of nitpicks :-). > > I haven't been through the whole driver yet, but I'll

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 15:09:37 Mark yao wrote: > On 2014?09?22? 23:54, Arnd Bergmann wrote: > > On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote: > + > + /* TODO(djkurtz): fetch the mapping start/size from somewhere */ > + mapping = arm_iommu_create_mapping(&plat

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Arnd Bergmann
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote: > > > + > > > + /* TODO(djkurtz): fetch the mapping start/size from somewhere */ > > > + mapping = arm_iommu_create_mapping(&platform_bus_type, 0x1000, > > > + SZ_1G); > > > + if (IS_ERR(mappi

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Boris BREZILLON
On Mon, 22 Sep 2014 16:43:31 +0200 Arnd Bergmann wrote: > On Monday 22 September 2014 18:48:54 Mark yao wrote: > > diff --git a/drivers/gpu/drm/rockchip/Kconfig > > b/drivers/gpu/drm/rockchip/Kconfig > > new file mode 100644 > > index 000..7146c80 > > --- /dev/null > > +++ b/drivers/gpu/drm/

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Arnd Bergmann
On Monday 22 September 2014 18:48:54 Mark yao wrote: > diff --git a/drivers/gpu/drm/rockchip/Kconfig > b/drivers/gpu/drm/rockchip/Kconfig > new file mode 100644 > index 000..7146c80 > --- /dev/null > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -0,0 +1,19 @@ > +config DRM_ROCKCHIP > + trist

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Boris BREZILLON
Hi Mark, You'll find some comments inline. Anyway, I wouldn't call it a review (your driver is using some concepts I'm not used to, like IOMMUs) but rather a collection of nitpicks :-). I haven't been through the whole driver yet, but I'll get back to it soon ;-). And remember this is a 2 way th

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Rob Clark
Ok, couple more small comments.. this time I actually had time to go through the entire patch, not just the uapi On Mon, Sep 22, 2014 at 6:48 AM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use t