Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-08-19 Thread Boris Brezillon
Hi Adrian, Sorry for chiming so late, but I think I have a few concerns with this patch. Nothing major, but I'd prefer to have it addressed now rather than in a follow-up series. On Tue, 16 Jul 2024 21:11:40 +0100 Adrián Larumbe wrote: > Enable calculations of job submission times in clock cycl

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-08-19 Thread Boris Brezillon
Hi, On Mon, 19 Aug 2024 08:48:24 +0100 Steven Price wrote: > Hi Adrián, > > On 31/07/2024 13:41, Adrián Larumbe wrote: > > Hi Steven, thanks for the remarks. > > > > On 19.07.2024 15:14, Steven Price wrote: > >> On 16/07/2024 21:11, Adrián Larumbe wrote: > >>> Enable calculations of job su

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-08-19 Thread Steven Price
Hi Adrián, On 31/07/2024 13:41, Adrián Larumbe wrote: > Hi Steven, thanks for the remarks. > > On 19.07.2024 15:14, Steven Price wrote: >> On 16/07/2024 21:11, Adrián Larumbe wrote: >>> Enable calculations of job submission times in clock cycles and wall >>> time. This is done by expanding the bo

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-07-31 Thread Adrián Larumbe
Hi Steven, thanks for the remarks. On 19.07.2024 15:14, Steven Price wrote: > On 16/07/2024 21:11, Adrián Larumbe wrote: > > Enable calculations of job submission times in clock cycles and wall > > time. This is done by expanding the boilerplate command stream when running > > a job to include ins

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-07-19 Thread Steven Price
On 16/07/2024 21:11, Adrián Larumbe wrote: > Enable calculations of job submission times in clock cycles and wall > time. This is done by expanding the boilerplate command stream when running > a job to include instructions that compute said times right before an after > a user CS. > > Those numbe

[PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-07-16 Thread Adrián Larumbe
Enable calculations of job submission times in clock cycles and wall time. This is done by expanding the boilerplate command stream when running a job to include instructions that compute said times right before an after a user CS. Those numbers are stored in the queue's group's sync objects BO, r