Re: [PATCH v4 1/3] drm/udl: Replace fbdev code with generic emulation

2019-11-13 Thread Thomas Zimmermann
Am 13.11.19 um 16:41 schrieb Thomas Zimmermann: >> Either way you choose: > > Glad you like it :) > more like this >> >> Btw, nice diffstat! Glad you like it :) >> >>> if (ret) >>> goto err; >>> >>> @@ -367,6 +368,4 @@ void udl_fini(struct drm_device *dev) >>> >>> if

Re: [PATCH v4 1/3] drm/udl: Replace fbdev code with generic emulation

2019-11-13 Thread Thomas Zimmermann
Hi Am 13.11.19 um 16:26 schrieb Noralf Trønnes: > > > Den 13.11.2019 12.52, skrev Thomas Zimmermann: >> The udl driver can use the generic fbdev implementation. Convert it. >> >> v4: >> * hardcode console bpp to 16 >> v3: >> * remove module parameter fb_bpp in favor of fbdev's video >>

Re: [PATCH v4 1/3] drm/udl: Replace fbdev code with generic emulation

2019-11-13 Thread Noralf Trønnes
Den 13.11.2019 12.52, skrev Thomas Zimmermann: > The udl driver can use the generic fbdev implementation. Convert it. > > v4: > * hardcode console bpp to 16 > v3: > * remove module parameter fb_bpp in favor of fbdev's video > * call drm_fbdev_generic_setup() directly; remove ud

[PATCH v4 1/3] drm/udl: Replace fbdev code with generic emulation

2019-11-13 Thread Thomas Zimmermann
The udl driver can use the generic fbdev implementation. Convert it. v4: * hardcode console bpp to 16 v3: * remove module parameter fb_bpp in favor of fbdev's video * call drm_fbdev_generic_setup() directly; remove udl_fbdev_init() * use default for struct drm_mode_