Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 08:37:32AM +0100, Thomas Zimmermann wrote: > Am 24.02.25 um 15:29 schrieb andriy.shevche...@linux.intel.com: > > On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: ... > > > +static void drm_fb_xrgb_to_bgr888_line(void *dbuf, const void *sbuf, > > > unsigned

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread Thomas Zimmermann
Hi Am 24.02.25 um 15:29 schrieb andriy.shevche...@linux.intel.com: On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. ... +static void drm_fb_xrgb_to_bgr888_line(void *dbuf, const void *sb

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 05:00:50PM +0200, andriy.shevche...@linux.intel.com wrote: > On Mon, Feb 24, 2025 at 02:54:07PM +, Aditya Garg wrote: > > This conversion helper mimics the existing drm_fb_xrgb_to_rgb888 helper > > Not really. See below. > > > > On 24 Feb 2025, at 7:59 PM, andriy.

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread Aditya Garg
> On 24 Feb 2025, at 8:30 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 02:54:07PM +, Aditya Garg wrote: >> This conversion helper mimics the existing drm_fb_xrgb_to_rgb888 helper > > Not really. See below. > >>> On 24 Feb 2025, at 7:59 PM, andriy.shevche...@

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 02:54:07PM +, Aditya Garg wrote: > This conversion helper mimics the existing drm_fb_xrgb_to_rgb888 helper Not really. See below. > > On 24 Feb 2025, at 7:59 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrot

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread Aditya Garg
This conversion helper mimics the existing drm_fb_xrgb_to_rgb888 helper > On 24 Feb 2025, at 7:59 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: >> From: Kerem Karabay >> >> Add XRGB emulation helper for devices that only su

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: > From: Kerem Karabay > > Add XRGB emulation helper for devices that only support BGR888. ... > +static void drm_fb_xrgb_to_bgr888_line(void *dbuf, const void *sbuf, > unsigned int pixels) Okay the xrgb is the actual pix

[PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread Aditya Garg
From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. Signed-off-by: Kerem Karabay Signed-off-by: Aditya Garg Reviewed-by: Thomas Zimmermann --- v2 -> Fix incorrect description v3 -> No change in this patch v4 -> No change in this patch drivers/gpu/drm/drm_