Re: [PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-12-01 Thread Liu Ying
On 12/01/2024, Uwe Kleine-König wrote: > Hello, Hello, > > On Mon, Nov 25, 2024 at 05:33:06PM +0800, Liu Ying wrote: >> +struct platform_driver dc_de_driver = { >> +.probe = dc_de_probe, >> +.remove_new = dc_de_remove, > > Please use .remove here. Also in a few other patches of this ser

Re: [PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-11-30 Thread Uwe Kleine-König
Hello, On Mon, Nov 25, 2024 at 05:33:06PM +0800, Liu Ying wrote: > +struct platform_driver dc_de_driver = { > + .probe = dc_de_probe, > + .remove_new = dc_de_remove, Please use .remove here. Also in a few other patches of this series. Best regards Uwe > + .driver = { > +

[PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-11-25 Thread Liu Ying
i.MX8qxp Display Controller display engine consists of all processing units that operate in a display clock domain. Add minimal feature support with FrameGen and TCon so that the engine can output display timings. The display engine driver as a master binds FrameGen and TCon drivers as components