Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-12-01 Thread Ville Syrjälä
On Wed, Nov 29, 2023 at 12:25:37PM +0200, Ville Syrjälä wrote: > On Wed, Nov 29, 2023 at 12:12:59PM +0200, Pekka Paalanen wrote: > > On Tue, 28 Nov 2023 15:49:08 +0200 > > Ville Syrjälä wrote: > > > > > Should we perhaps start to use the (arguably hideous) > > > - void f(struct foo *bar) > > >

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-12-01 Thread Ville Syrjälä
On Fri, Dec 01, 2023 at 10:01:49AM +0100, Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 11:18:24AM +0200, Ville Syrjälä wrote: > > On Wed, Nov 29, 2023 at 10:11:26AM +0100, Maxime Ripard wrote: > > > Hi Ville, > > > > > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > > > > On T

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-12-01 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 11:18:24AM +0200, Ville Syrjälä wrote: > On Wed, Nov 29, 2023 at 10:11:26AM +0100, Maxime Ripard wrote: > > Hi Ville, > > > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > > > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > > > On Tue,

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 01:40:38PM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Maxime Ripard wrote: > > On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: > >> On Wed, 29 Nov 2023, Maxime Ripard wrote: > >> > Hi Ville, > >> > > >> > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville S

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: >> On Wed, 29 Nov 2023, Maxime Ripard wrote: >> > Hi Ville, >> > >> > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: >> >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripa

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Maxime Ripard wrote: > > Hi Ville, > > > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > >> > On Tue, Nov 28, 2023 at 02:54:02P

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Ville Syrjälä
On Wed, Nov 29, 2023 at 12:12:59PM +0200, Pekka Paalanen wrote: > On Tue, 28 Nov 2023 15:49:08 +0200 > Ville Syrjälä wrote: > > > Should we perhaps start to use the (arguably hideous) > > - void f(struct foo *bar) > > + void f(struct foo bar[static 1]) > > syntax to tell the compiler we don't a

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Pekka Paalanen
On Tue, 28 Nov 2023 15:49:08 +0200 Ville Syrjälä wrote: > Should we perhaps start to use the (arguably hideous) > - void f(struct foo *bar) > + void f(struct foo bar[static 1]) > syntax to tell the compiler we don't accept NULL pointers? > > Hmm. Apparently that has the same problem as using a

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, Maxime Ripard wrote: > Hi Ville, > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: >> > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: >> > > On Tue, 28 Nov 2023, Maxime Ripard wr

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Ville Syrjälä
On Wed, Nov 29, 2023 at 10:11:26AM +0100, Maxime Ripard wrote: > Hi Ville, > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > > > On Tue, 28 Nov

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
Hi Ville, On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > > On Tue, 28 Nov 2023, Maxime Ripard wrote: > > > > All the drm_connector_init variants ta

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-28 Thread Ville Syrjälä
On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > Hi Jani, > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > On Tue, 28 Nov 2023, Maxime Ripard wrote: > > > All the drm_connector_init variants take at least a pointer to the > > > device, connector and hooks imple

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-28 Thread Maxime Ripard
Hi Jani, On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > On Tue, 28 Nov 2023, Maxime Ripard wrote: > > All the drm_connector_init variants take at least a pointer to the > > device, connector and hooks implementation. > > > > However, none of them check their value before dereferen

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-28 Thread Jani Nikula
On Tue, 28 Nov 2023, Maxime Ripard wrote: > All the drm_connector_init variants take at least a pointer to the > device, connector and hooks implementation. > > However, none of them check their value before dereferencing those > pointers which can lead to a NULL-pointer dereference if the author

[PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-28 Thread Maxime Ripard
All the drm_connector_init variants take at least a pointer to the device, connector and hooks implementation. However, none of them check their value before dereferencing those pointers which can lead to a NULL-pointer dereference if the author isn't careful. Let's test those pointers instead an