Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Rob Herring
On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Changesets are very powerful, but the lack of a helper API > makes using them cumbersome. Introduce a simple copy based > API that makes things considerably easier. > > To wit, adding a property using the raw A

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Geert Uytterhoeven
Hi Rob, On Wed, Feb 21, 2018 at 4:23 PM, Rob Herring wrote: > On Wed, Feb 21, 2018 at 4:21 AM, Geert Uytterhoeven > wrote: >> You missed one fix I have in my topic/overlays branch >> https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/overlays&id=150f95b9dec

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 4:21 AM, Geert Uytterhoeven wrote: > Hi Laurent, > > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart > wrote: >> From: Pantelis Antoniou >> >> Changesets are very powerful, but the lack of a helper API >> makes using them cumbersome. Introduce a simple copy based >> AP

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Laurent Pinchart
Hi Geert, On Wednesday, 21 February 2018 12:21:50 EET Geert Uytterhoeven wrote: > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Changesets are very powerful, but the lack of a helper API > > makes using them cumbersome. Introduce a simple copy base

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Changesets are very powerful, but the lack of a helper API > makes using them cumbersome. Introduce a simple copy based > API that makes things considerably easier. > > To wit, adding a property u

[PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-20 Thread Laurent Pinchart
From: Pantelis Antoniou Changesets are very powerful, but the lack of a helper API makes using them cumbersome. Introduce a simple copy based API that makes things considerably easier. To wit, adding a property using the raw API. struct property *prop; prop = kzalloc(sizeof(*pro