Re: [PATCH v4 04/12] drm/vc4: crtc: Fix vc4_get_crtc_encoder logic

2021-05-21 Thread Dave Stevenson
Hi Maxime On Fri, 7 May 2021 at 16:05, Maxime Ripard wrote: > > The vc4_get_crtc_encoder function currently only works when the > connector->state->crtc pointer is set, which is only true when the > connector is currently enabled. > > However, we use it as part of the disable path as well, and ou

[PATCH v4 04/12] drm/vc4: crtc: Fix vc4_get_crtc_encoder logic

2021-05-07 Thread Maxime Ripard
The vc4_get_crtc_encoder function currently only works when the connector->state->crtc pointer is set, which is only true when the connector is currently enabled. However, we use it as part of the disable path as well, and our lookup will fail in that case, resulting in it returning a null pointer