Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2020-01-01 Thread Laurent Pinchart
Hi Boris, On Fri, Dec 27, 2019 at 01:21:31PM +0100, Boris Brezillon wrote: > On Fri, 27 Dec 2019 12:51:54 +0200 Laurent Pinchart wrote: > > On Fri, Dec 27, 2019 at 10:42:25AM +0100, Andrzej Hajda wrote: > > > On 24.12.2019 10:44, Boris Brezillon wrote: > > > > On Tue, 24 Dec 2019 10:16:49 +0100

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-27 Thread Boris Brezillon
On Tue, 24 Dec 2019 12:31:11 +0100 Sam Ravnborg wrote: > Hi Boris. > > > Just a reminder of my 2 proposals: > > > > 1/ implement the bridge_ops->pre_enable/post_disable() hooks so you can > >split your enable/disable logic in 2 parts and make sure things are > >ready when the panel/next

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-27 Thread Boris Brezillon
On Fri, 27 Dec 2019 12:51:54 +0200 Laurent Pinchart wrote: > Hi Andrzej, > > On Fri, Dec 27, 2019 at 10:42:25AM +0100, Andrzej Hajda wrote: > > On 24.12.2019 10:44, Boris Brezillon wrote: > > > On Tue, 24 Dec 2019 10:16:49 +0100 Andrzej Hajda wrote: > > >> On 23.12.2019 10:55, Marek Szyprows

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-27 Thread Marek Szyprowski
Hi All, On 27.12.2019 11:25, Marek Szyprowski wrote: > On 24.12.2019 11:03, Boris Brezillon wrote: >> On Tue, 24 Dec 2019 10:49:36 +0100 >> Boris Brezillon wrote: >>> On Tue, 24 Dec 2019 10:44:22 +0100 >>> Boris Brezillon wrote: On Tue, 24 Dec 2019 10:16:49 +0100 Andrzej Hajda wrote:

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-27 Thread Laurent Pinchart
Hi Andrzej, On Fri, Dec 27, 2019 at 10:42:25AM +0100, Andrzej Hajda wrote: > On 24.12.2019 10:44, Boris Brezillon wrote: > > On Tue, 24 Dec 2019 10:16:49 +0100 Andrzej Hajda wrote: > >> On 23.12.2019 10:55, Marek Szyprowski wrote: > >>> On 16.12.2019 16:25, Boris Brezillon wrote: > On Mon,

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-27 Thread Marek Szyprowski
Hi Boris, On 24.12.2019 11:03, Boris Brezillon wrote: > On Tue, 24 Dec 2019 10:49:36 +0100 > Boris Brezillon wrote: >> On Tue, 24 Dec 2019 10:44:22 +0100 >> Boris Brezillon wrote: >>> On Tue, 24 Dec 2019 10:16:49 +0100 >>> Andrzej Hajda wrote: On 23.12.2019 10:55, Marek Szyprowski wrote: >

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-27 Thread Andrzej Hajda
On 24.12.2019 10:44, Boris Brezillon wrote: > On Tue, 24 Dec 2019 10:16:49 +0100 > Andrzej Hajda wrote: > >> On 23.12.2019 10:55, Marek Szyprowski wrote: >>> Hi Boris, >>> >>> On 16.12.2019 16:25, Boris Brezillon wrote: On Mon, 16 Dec 2019 16:02:36 +0100 Marek Szyprowski wrote:

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-24 Thread Laurent Pinchart
Hi Sam, On Tue, Dec 24, 2019 at 12:31:11PM +0100, Sam Ravnborg wrote: > > Just a reminder of my 2 proposals: > > > > 1/ implement the bridge_ops->pre_enable/post_disable() hooks so you can > >split your enable/disable logic in 2 parts and make sure things are > >ready when the panel/next

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-24 Thread Sam Ravnborg
Hi Boris. > Just a reminder of my 2 proposals: > > 1/ implement the bridge_ops->pre_enable/post_disable() hooks so you can >split your enable/disable logic in 2 parts and make sure things are >ready when the panel/next bridge tries to send DSI commands > 2/ move everything that's needed t

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-24 Thread Boris Brezillon
On Tue, 24 Dec 2019 10:49:36 +0100 Boris Brezillon wrote: > On Tue, 24 Dec 2019 10:44:22 +0100 > Boris Brezillon wrote: > > > On Tue, 24 Dec 2019 10:16:49 +0100 > > Andrzej Hajda wrote: > > > > > On 23.12.2019 10:55, Marek Szyprowski wrote: > > > > Hi Boris, > > > > > > > > On 16.12.201

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-24 Thread Boris Brezillon
On Tue, 24 Dec 2019 10:44:22 +0100 Boris Brezillon wrote: > On Tue, 24 Dec 2019 10:16:49 +0100 > Andrzej Hajda wrote: > > > On 23.12.2019 10:55, Marek Szyprowski wrote: > > > Hi Boris, > > > > > > On 16.12.2019 16:25, Boris Brezillon wrote: > > >> On Mon, 16 Dec 2019 16:02:36 +0100 > > >>

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-24 Thread Boris Brezillon
On Tue, 24 Dec 2019 10:16:49 +0100 Andrzej Hajda wrote: > On 23.12.2019 10:55, Marek Szyprowski wrote: > > Hi Boris, > > > > On 16.12.2019 16:25, Boris Brezillon wrote: > >> On Mon, 16 Dec 2019 16:02:36 +0100 > >> Marek Szyprowski wrote: > >>> Hi Boris, > >>> > >>> On 16.12.2019 15:55, Boris

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-24 Thread Andrzej Hajda
On 23.12.2019 10:55, Marek Szyprowski wrote: > Hi Boris, > > On 16.12.2019 16:25, Boris Brezillon wrote: >> On Mon, 16 Dec 2019 16:02:36 +0100 >> Marek Szyprowski wrote: >>> Hi Boris, >>> >>> On 16.12.2019 15:55, Boris Brezillon wrote: On Mon, 16 Dec 2019 14:54:25 +0100 Marek Szyprowski

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-23 Thread Marek Szyprowski
Hi Boris, On 16.12.2019 16:25, Boris Brezillon wrote: > On Mon, 16 Dec 2019 16:02:36 +0100 > Marek Szyprowski wrote: >> Hi Boris, >> >> On 16.12.2019 15:55, Boris Brezillon wrote: >>> On Mon, 16 Dec 2019 14:54:25 +0100 >>> Marek Szyprowski wrote: On 03.12.2019 15:15, Boris Brezillon wrote:

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-16 Thread Boris Brezillon
On Mon, 16 Dec 2019 16:02:36 +0100 Marek Szyprowski wrote: > Hi Boris, > > On 16.12.2019 15:55, Boris Brezillon wrote: > > On Mon, 16 Dec 2019 14:54:25 +0100 > > Marek Szyprowski wrote: > >> On 03.12.2019 15:15, Boris Brezillon wrote: > >>> So that each element in the chain can easily acces

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-16 Thread Marek Szyprowski
Hi Boris, On 16.12.2019 15:55, Boris Brezillon wrote: > On Mon, 16 Dec 2019 14:54:25 +0100 > Marek Szyprowski wrote: >> On 03.12.2019 15:15, Boris Brezillon wrote: >>> So that each element in the chain can easily access its predecessor. >>> This will be needed to support bus format negotiation be

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-16 Thread Boris Brezillon
Hello Marek, On Mon, 16 Dec 2019 14:54:25 +0100 Marek Szyprowski wrote: > Hi All, > > On 03.12.2019 15:15, Boris Brezillon wrote: > > So that each element in the chain can easily access its predecessor. > > This will be needed to support bus format negotiation between elements > > of the bridge

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-16 Thread Marek Szyprowski
Hi All, On 03.12.2019 15:15, Boris Brezillon wrote: > So that each element in the chain can easily access its predecessor. > This will be needed to support bus format negotiation between elements > of the bridge chain. > > Signed-off-by: Boris Brezillon > Reviewed-by: Neil Armstrong > Reviewed-b

[PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-03 Thread Boris Brezillon
So that each element in the chain can easily access its predecessor. This will be needed to support bus format negotiation between elements of the bridge chain. Signed-off-by: Boris Brezillon Reviewed-by: Neil Armstrong Reviewed-by: Laurent Pinchart --- Changes in v4: * Simplify the drm_bridge_