Re: [PATCH v4 02/19] drm: add drmm_encoder_alloc()

2020-12-10 Thread Daniel Vetter
On Thu, Dec 10, 2020 at 12:59 PM Philipp Zabel wrote: > > Hi Daniel, > > thank you for the review. I'll work in all your other comments, there's > just one I'm not sure what to do about: > > On Wed, 2020-12-09 at 17:05 +0100, Daniel Vetter wrote: > [...] > > > +void *__drmm_encoder_alloc(struct dr

Re: [PATCH v4 02/19] drm: add drmm_encoder_alloc()

2020-12-10 Thread Philipp Zabel
Hi Daniel, thank you for the review. I'll work in all your other comments, there's just one I'm not sure what to do about: On Wed, 2020-12-09 at 17:05 +0100, Daniel Vetter wrote: [...] > > +void *__drmm_encoder_alloc(struct drm_device *dev, size_t size, size_t > > offset, > > +

Re: [PATCH v4 02/19] drm: add drmm_encoder_alloc()

2020-12-09 Thread Daniel Vetter
On Tue, Dec 08, 2020 at 04:54:34PM +0100, Philipp Zabel wrote: > Add an alternative to drm_encoder_init() that allocates and initializes > an encoder and registers drm_encoder_cleanup() with > drmm_add_action_or_reset(). > > Signed-off-by: Philipp Zabel > Reviewed-by: Laurent Pinchart > --- > Ch

[PATCH v4 02/19] drm: add drmm_encoder_alloc()

2020-12-08 Thread Philipp Zabel
Add an alternative to drm_encoder_init() that allocates and initializes an encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart --- Changes since v3: - allow the funcs parameter to __drmm_encoder_alloc() to be NU