Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:32, Frank Binns wrote: > Hi Krzysztof, > > On Mon, 2023-07-17 at 09:29 +0200, Krzysztof Kozlowski wrote: >> On 14/07/2023 16:25, Sarah Walker wrote: >>> Add the device tree binding documentation for the Series AXE GPU used in >>> TI AM62 SoCs. >>> >> >> ... >> >>> + >>> + clocks:

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:47, Frank Binns wrote: > Hi Krzysztof, > > On Tue, 2023-07-18 at 08:20 +0200, Krzysztof Kozlowski wrote: >> On 14/07/2023 16:25, Sarah Walker wrote: >>> Add the device tree binding documentation for the Series AXE GPU used in >>> TI AM62 SoCs. >>> >> >> ... >> >>> + >>> +additiona

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:36, Frank Binns wrote: > Hi Krzysztof, > > On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote: >> On 18/07/2023 13:08, Frank Binns wrote: And this items: - const: gpu can just be const: gpu Although, if there is only one interrupt thi

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Tue, 2023-07-18 at 08:20 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:25, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > ... > > > + > > +additionalProperties: false > > + > > +examples: > > +

Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote: > On 18/07/2023 13:08, Frank Binns wrote: > > > And this > > > items: > > > - const: gpu > > > can just be > > > const: gpu > > > > > > Although, if there is only one interrupt this is probably not > > > particularly he

Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Mon, 2023-07-17 at 09:29 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:25, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > ... > > > + > > + clocks: > > +minItems: 1 > > +maxItems: 3 > >

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread mrip...@kernel.org
Hi, To expand on what Krzysztof said On Tue, Jul 18, 2023 at 01:10:14PM +0200, Krzysztof Kozlowski wrote: > On 18/07/2023 13:08, Frank Binns wrote: > >> And this > >> items: > >> - const: gpu > >> can just be > >> const: gpu > >> > >> Although, if there is only one interrupt this is probably no

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:08, Frank Binns wrote: >> And this >> items: >> - const: gpu >> can just be >> const: gpu >> >> Although, if there is only one interrupt this is probably not >> particularly helpful. Are there other implementations of this IP that >> have more interrupts? > > No, all our current

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Conor, Thank you for your feedback (comments below). On Sat, 2023-07-15 at 11:40 +0100, Conor Dooley wrote: > Hey Sarah, > > Your series does not appear to be threaded. `git send-email` can be > passed, for example, a directory containing a whole series & will set > the correct in-reply-to he

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-17 Thread Krzysztof Kozlowski
On 14/07/2023 16:25, Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > ... > + > +additionalProperties: false > + > +examples: > + - | > +#include > +#include > + > +gpu: gpu@fd0 { > +compatible = "ti,am62-

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-17 Thread Krzysztof Kozlowski
On 14/07/2023 16:25, Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > ... > + > + clocks: > +minItems: 1 > +maxItems: 3 > + > + clock-names: > +items: > + - const: core > + - const: mem > + - const: sys

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-15 Thread Conor Dooley
Hey Sarah, Your series does not appear to be threaded. `git send-email` can be passed, for example, a directory containing a whole series & will set the correct in-reply-to headers so that the series is in a single thread. On Fri, Jul 14, 2023 at 03:25:26PM +0100, Sarah Walker wrote: > Add the de

[PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-14 Thread Sarah Walker
Add the device tree binding documentation for the Series AXE GPU used in TI AM62 SoCs. Changes since v3: - Remove oneOf in compatible property - Remove power-supply (not used on AM62) Changes since v2: - Add commit message description - Remove mt8173-gpu support (not currently supported) - Drop q