[PATCH v4 01/14] drm: Centralize format information

2016-09-16 Thread Laurent Pinchart
Hi Tomi, On Friday 16 Sep 2016 12:44:31 Tomi Valkeinen wrote: > On 16/09/16 02:30, Laurent Pinchart wrote: > > I've checked the existing code that this patch series is replacing, and > > the [ARGB]{4} formats are currently reported as having a depth of 32. > > I'm not sure why that's the case,

[PATCH v4 01/14] drm: Centralize format information

2016-09-16 Thread Tomi Valkeinen
On 16/09/16 02:30, Laurent Pinchart wrote: > I've checked the existing code that this patch series is replacing, and the > [ARGB]{4} formats are currently reported as having a depth of 32. I'm not > sure why that's the case, but I'd rather not touch it in this patch. If this > is a bug we s

[PATCH v4 01/14] drm: Centralize format information

2016-09-16 Thread Laurent Pinchart
Hello, On Thursday 15 Sep 2016 17:12:12 Eric Engestrom wrote: > On Thu, Sep 15, 2016 at 09:22:54AM +0300, Tomi Valkeinen wrote: > > On 15/09/16 01:22, Laurent Pinchart wrote: > >> No, the depth value is the number of colour bits, excluding the alpha > >> bits. This is used to implement the fbdev c

[PATCH v4 01/14] drm: Centralize format information

2016-09-15 Thread Eric Engestrom
On Thu, Sep 15, 2016 at 09:22:54AM +0300, Tomi Valkeinen wrote: > On 15/09/16 01:22, Laurent Pinchart wrote: > > No, the depth value is the number of colour bits, excluding the alpha bits. > > This is used to implement the fbdev compatibility code, as fbdev (unlike > > kms) > > makes use of that

[PATCH v4 01/14] drm: Centralize format information

2016-09-15 Thread Tomi Valkeinen
On 15/09/16 01:22, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the review. > > On Wednesday 14 Sep 2016 14:49:26 Tomi Valkeinen wrote: >> On 08/09/16 17:44, Laurent Pinchart wrote: >>> Various pieces of information about DRM formats (number of planes, color >>> depth, chroma subsampling,

[PATCH v4 01/14] drm: Centralize format information

2016-09-15 Thread Laurent Pinchart
Hi Tomi, Thank you for the review. On Wednesday 14 Sep 2016 14:49:26 Tomi Valkeinen wrote: > On 08/09/16 17:44, Laurent Pinchart wrote: > > Various pieces of information about DRM formats (number of planes, color > > depth, chroma subsampling, ...) are scattered across different helper > > functi

[PATCH v4 01/14] drm: Centralize format information

2016-09-14 Thread Tomi Valkeinen
On 08/09/16 17:44, Laurent Pinchart wrote: > Various pieces of information about DRM formats (number of planes, color > depth, chroma subsampling, ...) are scattered across different helper > functions in the DRM core. Callers of those functions often need to > access more than a single parameter o

[PATCH v4 01/14] drm: Centralize format information

2016-09-08 Thread Laurent Pinchart
Various pieces of information about DRM formats (number of planes, color depth, chroma subsampling, ...) are scattered across different helper functions in the DRM core. Callers of those functions often need to access more than a single parameter of the format, leading to inefficiencies due to mult