Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-04-25 Thread Andrew Morton
On Thu, 13 Mar 2025 11:43:15 + Alessandro Carminati wrote: > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. I've had

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-29 Thread David Gow
On Thu, 13 Mar 2025 at 19:44, Alessandro Carminati wrote: > > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. > > Such inten

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Andrew Morton
On Fri, 28 Mar 2025 16:14:55 -0600 Shuah Khan wrote: > On 3/13/25 16:05, Andrew Morton wrote: > > On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: > > > >> On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > Yeah, as with my prior review, I'm a fan of this. It ma

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Shuah Khan
On 3/13/25 16:05, Andrew Morton wrote: On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my very noisy tests much easier to deal with. And for the reco

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Maxime Ripard
On Fri, Mar 28, 2025 at 11:38:23AM +0100, Mickaël Salaün wrote: > On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Thu, Mar 13, 2025 at 10:17:49AM -0700, Kees Cook wrote: > > > On Thu, Mar 13, 2025 at 11:43:15AM +, Alessandro Carminati wrote: > > > > Some unit

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Mickaël Salaün
On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Mar 13, 2025 at 10:17:49AM -0700, Kees Cook wrote: > > On Thu, Mar 13, 2025 at 11:43:15AM +, Alessandro Carminati wrote: > > > Some unit tests intentionally trigger warning backtraces by passing bad > > > paramete

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Andrew Morton
On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: > On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > > > > > Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my > > > very noisy tests much easier to deal with. > > > > And for the record, we're also a

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Guenter Roeck
On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > > > Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my > > very noisy tests much easier to deal with. > > And for the record, we're also affected by this in DRM and would very > much like to get it merged in

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Maxime Ripard
Hi, On Thu, Mar 13, 2025 at 10:17:49AM -0700, Kees Cook wrote: > On Thu, Mar 13, 2025 at 11:43:15AM +, Alessandro Carminati wrote: > > Some unit tests intentionally trigger warning backtraces by passing bad > > parameters to kernel API functions. Such unit tests typically check the > > return

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Kees Cook
On Thu, Mar 13, 2025 at 11:43:15AM +, Alessandro Carminati wrote: > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. Than

[PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-13 Thread Alessandro Carminati
Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful