Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Pekka Paalanen
On Fri, 12 Nov 2021 12:20:14 +0100 Javier Martinez Canillas wrote: > On 11/12/21 11:57, Thomas Zimmermann wrote: > > [snip] > > >>> > >>> This is what HW-specific drivers want to query in their init/probing > >>> code. The actual semantics of this decision is hidden from the driver. > >>> It's

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Thomas Zimmermann
Hi Am 12.11.21 um 12:20 schrieb Javier Martinez Canillas: On 11/12/21 11:57, Thomas Zimmermann wrote: [snip] This is what HW-specific drivers want to query in their init/probing code. The actual semantics of this decision is hidden from the driver. It's also easier to read than the other nam

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Javier Martinez Canillas
On 11/12/21 11:57, Thomas Zimmermann wrote: [snip] >>> >>> This is what HW-specific drivers want to query in their init/probing >>> code. The actual semantics of this decision is hidden from the driver. >>> It's also easier to read than the other name IMHO >> >> Ok, but what is a "native driver"?

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Thomas Zimmermann
Hi Am 12.11.21 um 11:22 schrieb Pekka Paalanen: On Fri, 12 Nov 2021 11:09:13 +0100 Thomas Zimmermann wrote: Hi Am 12.11.21 um 10:39 schrieb Javier Martinez Canillas: Hello Pekka, On 11/12/21 09:56, Pekka Paalanen wrote: [snip] Hi, these ideas make sense to me, so FWIW, Acked-by: P

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Jani Nikula
On Fri, 12 Nov 2021, Pekka Paalanen wrote: > On Fri, 12 Nov 2021 11:09:13 +0100 > Thomas Zimmermann wrote: > >> Hi >> >> Am 12.11.21 um 10:39 schrieb Javier Martinez Canillas: >> > Hello Pekka, >> > >> > On 11/12/21 09:56, Pekka Paalanen wrote: >> > >> > [snip] >> > >> >> >> >> Hi, >> >> >>

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Javier Martinez Canillas
On 11/12/21 11:22, Pekka Paalanen wrote: [snip] >>> As this is just returning bool without changing anything, the usual word to use is "is". Since this function is also used at most once per driver, which is rarely, it could have a long and descriptive name. For exampl

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Pekka Paalanen
On Fri, 12 Nov 2021 11:09:13 +0100 Thomas Zimmermann wrote: > Hi > > Am 12.11.21 um 10:39 schrieb Javier Martinez Canillas: > > Hello Pekka, > > > > On 11/12/21 09:56, Pekka Paalanen wrote: > > > > [snip] > > > >> > >> Hi, > >> > >> these ideas make sense to me, so FWIW, > >> > >> Acked-by:

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Thomas Zimmermann
Hi Am 12.11.21 um 10:39 schrieb Javier Martinez Canillas: Hello Pekka, On 11/12/21 09:56, Pekka Paalanen wrote: [snip] Hi, these ideas make sense to me, so FWIW, Acked-by: Pekka Paalanen Thanks. There is one nitpick I'd like to ask about: +bool drm_get_modeset(void) +{ + return

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Javier Martinez Canillas
Hello Pekka, On 11/12/21 09:56, Pekka Paalanen wrote: [snip] > > Hi, > > these ideas make sense to me, so FWIW, > > Acked-by: Pekka Paalanen > Thanks. > There is one nitpick I'd like to ask about: > > +bool drm_get_modeset(void) > +{ > + return !drm_nomodeset; > +} > +EXPORT_SYMBOL(drm_ge

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-12 Thread Pekka Paalanen
On Mon, 8 Nov 2021 15:17:13 +0100 Thomas Zimmermann wrote: > Hi > > Am 08.11.21 um 15:06 schrieb Javier Martinez Canillas: > > There is a lot of historical baggage on this parameter. It is defined in > > the vgacon driver as nomodeset, but its set function is called text_mode() > > and the value

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 15:06 schrieb Javier Martinez Canillas: There is a lot of historical baggage on this parameter. It is defined in the vgacon driver as nomodeset, but its set function is called text_mode() and the value queried with a function named vgacon_text_force(). All this implies that it

[PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Javier Martinez Canillas
There is a lot of historical baggage on this parameter. It is defined in the vgacon driver as nomodeset, but its set function is called text_mode() and the value queried with a function named vgacon_text_force(). All this implies that it's about forcing text mode for VGA, yet it is not used in nei