Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-13 Thread Krzysztof Niemiec
Hi Janusz, On 2025-03-12 at 17:58:13 GMT, Janusz Krzysztofik wrote: > Hi Krzysztof, > > Thanks for looking at this. > > On Wednesday, 12 March 2025 16:06:15 CET Krzysztof Niemiec wrote: > > On 2025-03-11 at 21:04:56 GMT, Janusz Krzysztofik wrote: > > > Starting with commit ec3e00b4ee27 ("drm/i91

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-13 Thread Janusz Krzysztofik
On Thursday, 13 March 2025 14:11:35 CET Krzysztof Niemiec wrote: > Hi Janusz, > > On 2025-03-12 at 17:58:13 GMT, Janusz Krzysztofik wrote: > > Hi Krzysztof, > > > > Thanks for looking at this. > > > > On Wednesday, 12 March 2025 16:06:15 CET Krzysztof Niemiec wrote: > > > On 2025-03-11 at 21:04:

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-12 Thread Janusz Krzysztofik
Hi Krzysztof, Thanks for looking at this. On Wednesday, 12 March 2025 16:06:15 CET Krzysztof Niemiec wrote: > On 2025-03-11 at 21:04:56 GMT, Janusz Krzysztofik wrote: > > Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if > > drm_dev_register() fails"), we return from i915_driver_r

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-12 Thread Krzysztof Niemiec
On 2025-03-11 at 21:04:56 GMT, Janusz Krzysztofik wrote: > Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if > drm_dev_register() fails"), we return from i915_driver_register() > immediately if drm_dev_register() fails, skipping remaining registration > steps, and continue only with

[PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-11 Thread Janusz Krzysztofik
Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if drm_dev_register() fails"), we return from i915_driver_register() immediately if drm_dev_register() fails, skipping remaining registration steps, and continue only with remaining probe steps. However, the _unregister() counterpart c