Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-21 Thread Andy Shevchenko
On Wed, Aug 21, 2024 at 06:52:10AM +0300, Raag Jadav wrote: > On Tue, Aug 20, 2024 at 05:49:23PM -0400, Rodrigo Vivi wrote: > > On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > > > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > > > On Fri, Aug 09, 2024 at 02:48:08PM +0

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-21 Thread Andy Shevchenko
On Tue, Aug 20, 2024 at 05:49:23PM -0400, Rodrigo Vivi wrote: > On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: ... > > > I don't understand what inte

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Tue, Aug 20, 2024 at 05:49:23PM -0400, Rodrigo Vivi wrote: > On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > > On Fri, Aug 09, 2024 at 11:45:25

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Rodrigo Vivi
On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > > Add hwmon support for fan1_input a

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > Add hwmon support for fan1_input attribute, which will expose fan speed > > > in RPM. With this in pla

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-19 Thread Andi Shyti
Hi Raag, I'm sorry, I missed this mail. On Mon, Aug 19, 2024 at 09:50:13AM +0300, Raag Jadav wrote: > On Wed, Aug 14, 2024 at 02:07:44PM +0530, Nilawar, Badal wrote: > > On 09-08-2024 15:46, Andi Shyti wrote: > > > > > +static int > > > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-18 Thread Raag Jadav
On Wed, Aug 14, 2024 at 02:07:44PM +0530, Nilawar, Badal wrote: > > Hi Andi, > > On 09-08-2024 15:46, Andi Shyti wrote: > > Hi Badal, > > > > > > +static int > > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > > > +{ > > > > + struct i915_hwmon *hwmon = ddat->hwmon; >

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-14 Thread Nilawar, Badal
Hi Andi, On 09-08-2024 15:46, Andi Shyti wrote: Hi Badal, +static int +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) +{ + struct i915_hwmon *hwmon = ddat->hwmon; + struct hwm_fan_info *fi = &ddat->fi; + u32 reg_val, pulses, time, time_now; + intel_wakere

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Andy Shevchenko
On Tue, Aug 13, 2024 at 03:53:25PM +0300, Raag Jadav wrote: > On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote: > > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > > On Fri, Aug 09, 2024 at 11:45

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote: > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > ... > > > > > + /* > > >

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Andy Shevchenko
On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: ... > > > + /* > > > + * HW register value is accumulated count of pulses from > > > + * PWM fan with th

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > + /* > > +* HW register value is accumulated count of pulses from > > +* PWM fan with the scale of 2 pulses per rotation. > > +*/ > > + rotations = p

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andi Shyti
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andy Shevchenko
On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > Add hwmon support for fan1_input attribute, which will expose fan speed > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > $ sensors > i915-pci-0300 > Adapter: PCI adapter > in0: 653.00 mV > fan1:

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andi Shyti
Hi Badal, > > +static int > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + struct hwm_fan_info *fi = &ddat->fi; > > + u32 reg_val, pulses, time, time_now; > > + intel_wakeref_t wakeref; > > + long rotations; > > +

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 03:03:20PM +0530, Nilawar, Badal wrote: > > > On 09-08-2024 11:45, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensors > > i915-pci-0

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Nilawar, Badal
On 09-08-2024 11:45, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

[PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-08 Thread Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1: N/A (max = 43.00 W) energy1: 32.02 k