Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-23 Thread Brian Starkey
On Tue, Jun 23, 2020 at 10:45:51AM +0200, Daniel Vetter wrote: > On Mon, Jun 22, 2020 at 11:20:51AM +0100, Brian Starkey wrote: > > On Fri, Jun 19, 2020 at 06:36:17PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 19, 2020 at 01:39:34PM +0100, Brian Starkey wrote: > > > > Hi Simon, > > > > > > > >

Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 11:20:51AM +0100, Brian Starkey wrote: > On Fri, Jun 19, 2020 at 06:36:17PM +0200, Daniel Vetter wrote: > > On Fri, Jun 19, 2020 at 01:39:34PM +0100, Brian Starkey wrote: > > > Hi Simon, > > > > > > On Fri, Jun 19, 2020 at 11:12:25AM +, Simon Ser wrote: > > > > There ha

Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-22 Thread Brian Starkey
On Fri, Jun 19, 2020 at 06:36:17PM +0200, Daniel Vetter wrote: > On Fri, Jun 19, 2020 at 01:39:34PM +0100, Brian Starkey wrote: > > Hi Simon, > > > > On Fri, Jun 19, 2020 at 11:12:25AM +, Simon Ser wrote: > > > There have suggestions to bake pitch alignment, address alignement, > > > contiguou

Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-19 Thread Daniel Vetter
On Fri, Jun 19, 2020 at 01:39:34PM +0100, Brian Starkey wrote: > Hi Simon, > > On Fri, Jun 19, 2020 at 11:12:25AM +, Simon Ser wrote: > > There have suggestions to bake pitch alignment, address alignement, > > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) > > constraints int

Re: [PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-19 Thread Brian Starkey
Hi Simon, On Fri, Jun 19, 2020 at 11:12:25AM +, Simon Ser wrote: > There have suggestions to bake pitch alignment, address alignement, > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) > constraints into modifiers. Last time this was brought up it seemed > like the consensus w

[PATCH v4] drm/fourcc: document modifier uniqueness requirements

2020-06-19 Thread Simon Ser
There have suggestions to bake pitch alignment, address alignement, contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) constraints into modifiers. Last time this was brought up it seemed like the consensus was to not allow this. Document this in drm_fourcc.h. There are several reason