Re: [PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-12 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 07:13:31PM +0200, Ville Syrjälä wrote: > On Tue, Feb 11, 2020 at 06:02:33PM +0100, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 06:22:06PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Many drivers are populating encoder->possible_clones wrong. Let'

Re: [PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-11 Thread Ville Syrjälä
On Tue, Feb 11, 2020 at 06:02:33PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 06:22:06PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Many drivers are populating encoder->possible_clones wrong. Let's > > persuade them to get it right by adding some loud WARNs. > > > > W

Re: [PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:22:06PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Many drivers are populating encoder->possible_clones wrong. Let's > persuade them to get it right by adding some loud WARNs. > > We'll cross check the bits between any two encoders. So either > both encoders

[PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä Many drivers are populating encoder->possible_clones wrong. Let's persuade them to get it right by adding some loud WARNs. We'll cross check the bits between any two encoders. So either both encoders can clone with the other, or neither can. We'll also complain about effecti