Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread dillon min
Hi Linus, Linus Walleij 于2020年5月14日周四 下午10:08写道: > > On Thu, May 14, 2020 at 12:22 PM dillon min wrote: > > > > > + /* Gamma */ > > > > + mipi_dbi_command(dbi, ILI9341_3GAMMA_EN, 0x00); > > > > + mipi_dbi_command(dbi, MIPI_DCS_SET_GAMMA_CURVE, 0x01); > > > > + mipi_dbi_co

Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread dillon min
Hi Linus, Thanks for reviewing. On Thu, May 14, 2020 at 4:14 PM Linus Walleij wrote: > > Hi Dillon, > > thanks for your patch! Overall this looks like a good start. > > On Tue, May 12, 2020 at 9:04 AM wrote: > > > #define ILI9341_SLEEP_OUT0x11 /* Sleep out register */ > > This is

Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread Linus Walleij
On Thu, May 14, 2020 at 12:22 PM dillon min wrote: > > > + /* Gamma */ > > > + mipi_dbi_command(dbi, ILI9341_3GAMMA_EN, 0x00); > > > + mipi_dbi_command(dbi, MIPI_DCS_SET_GAMMA_CURVE, 0x01); > > > + mipi_dbi_command(dbi, ILI9341_PGAMMA, > > > +0x0f,

Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread Linus Walleij
Hi Dillon, thanks for your patch! Overall this looks like a good start. On Tue, May 12, 2020 at 9:04 AM wrote: > #define ILI9341_SLEEP_OUT0x11 /* Sleep out register */ This is not a register, also just use MIPI_DCS_EXIT_SLEEP_MODE in the code. > +#define ILI9341_DFC

[PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-12 Thread dillon . minfei
From: dillon min Currently, we can use tinydrm ili9341 driver to drive ili9341 panel by spi interface (both register configuration and video) ili9341 have parallel and mcu interface as well, we extend the support to parallel rgb interface with DRM_MODE_CONNECTOR_DPI this driver can work as para