Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Guenter Roeck
On 3/24/22 12:18, Thomas Zimmermann wrote: Hi Am 24.03.22 um 20:11 schrieb Guenter Roeck: Hi, On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: Improve the performance of cfb_imageblit() by manually unrolling the inner blitting loop and moving some invariants out. The compile

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Guenter Roeck
Hi, On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: > Improve the performance of cfb_imageblit() by manually unrolling > the inner blitting loop and moving some invariants out. The compiler > failed to do this automatically. This change keeps cfb_imageblit() > in sync with sys_i

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Thomas Zimmermann
Hi Am 24.03.22 um 20:11 schrieb Guenter Roeck: Hi, On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: Improve the performance of cfb_imageblit() by manually unrolling the inner blitting loop and moving some invariants out. The compiler failed to do this automatically. This chan

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Geert Uytterhoeven
Hi Javier, On Thu, Feb 24, 2022 at 10:03 AM Javier Martinez Canillas wrote: > On 2/23/22 21:25, Sam Ravnborg wrote: > > Question: What is cfb an abbreviation for anyway? > > Not related to the patch - but if I have known the memory is lost.. > > I was curious so I dug on this. It seems CFB stands

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Sam Ravnborg
Hi Javier, On Thu, Feb 24, 2022 at 10:02:59AM +0100, Javier Martinez Canillas wrote: > Hello Sam, > > On 2/23/22 21:25, Sam Ravnborg wrote: > > [snip] > > > > > Question: What is cfb an abbreviation for anyway? > > Not related to the patch - but if I have known the memory is lost.. > > > > I

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Javier Martinez Canillas
Hello Sam, On 2/23/22 21:25, Sam Ravnborg wrote: [snip] > > Question: What is cfb an abbreviation for anyway? > Not related to the patch - but if I have known the memory is lost.. > I was curious so I dug on this. It seems CFB stands for Color Frame Buffer. Doing a `git grep "(CFB)"` in the l

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Javier Martinez Canillas
On 2/23/22 20:38, Thomas Zimmermann wrote: > Improve the performance of cfb_imageblit() by manually unrolling > the inner blitting loop and moving some invariants out. The compiler > failed to do this automatically. This change keeps cfb_imageblit() > in sync with sys_imagebit(). > > A microbenchm

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-23 Thread Sam Ravnborg
On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: > Improve the performance of cfb_imageblit() by manually unrolling > the inner blitting loop and moving some invariants out. The compiler > failed to do this automatically. This change keeps cfb_imageblit() > in sync with sys_imageb

[PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-23 Thread Thomas Zimmermann
Improve the performance of cfb_imageblit() by manually unrolling the inner blitting loop and moving some invariants out. The compiler failed to do this automatically. This change keeps cfb_imageblit() in sync with sys_imagebit(). A microbenchmark measures the average number of CPU cycles for cfb_i