Re: [PATCH v3 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-26 Thread Jakob Hauser
Hi Linus, On 25.10.24 21:27, Linus Walleij wrote: ... On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser wrote: +static const int s6e88a0_ams427ap24_br_to_cd[NUM_STEPS_CANDELA] = { (...) + /* brightness till, candela */ Brightness to candela conversion table? Edit comment? In the downst

Re: [PATCH v3 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-25 Thread Linus Walleij
Hi Jakob, thanks for your patch! On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser wrote: > +static const int s6e88a0_ams427ap24_br_to_cd[NUM_STEPS_CANDELA] = { (...) > + /* brightness till, candela */ Brightness to candela conversion table? Edit comment? > +static const u8 s6e88a0_ams427ap2

[PATCH v3 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-24 Thread Jakob Hauser
The tables for brightness to candela, aid and elvss were taken from downstream kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [1][2][3]. The gamma table gets generated in "ss_dsi_smart_dimming_S6E88A0_AMS427AP24.c" [4] with hard-coded starting values. The function smart_dimming_in